Skip to content

Add ceph tentacle CI jobs #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 5 commits into from
Apr 30, 2025
Merged

Add ceph tentacle CI jobs #1106

mergify merged 5 commits into from
Apr 30, 2025

Conversation

@anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Apr 29, 2025 •
edited
Loading

depends on #1108

@anoopcs9 anoopcs9 force-pushed the add-tentacle-ci branch 3 times, most recently from 6322614 to d1436bd Compare April 29, 2025 08:52
@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Apr 29, 2025

Thanks for working on this!

The test failures match and appear to be happening on our master branch for ceph main too. An RGW suite is failing but in a non-obvious way. Do you think you have time to look into that as a prereq for adding tentacle? Thanks!

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Apr 30, 2025

Thanks for working on this!

The test failures match and appear to be happening on our master branch for ceph main too. An RGW suite is failing but in a non-obvious way. Do you think you have time to look into that as a prereq for adding tentacle? Thanks!

Sure, let me check if it can be locally reproduced.

@anoopcs9 anoopcs9 marked this pull request as ready for review April 30, 2025 08:45
@anoopcs9 anoopcs9 requested a review from phlogistonjohn April 30, 2025 08:46
@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Apr 30, 2025
@dpulls
Copy link

dpulls bot commented Apr 30, 2025

🎉 All dependencies have been resolved !

@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Apr 30, 2025

@Mergifyio rebase

anoopcs9 added 5 commits April 30, 2025 11:00
@anoopcs9 @phlogistonjohn
internal/util: Add version check for tentacle
0458555 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 @phlogistonjohn
cephfs: Add version check for tentacle
ab74e57 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 @phlogistonjohn
cephfs/admin: Adjust build tags in tests for tentacle
978cd37 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 @phlogistonjohn
Makefile: Add ceph tentacle versions
8816466 
Add CEPH_VERSION values for tentacle and pre-tentacle. This will allow
building and testing with ceph tentacle images.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 @phlogistonjohn
workflows: Add tentacle jobs to the CI matrix
093e14c 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@mergify
Copy link

mergify bot commented Apr 30, 2025

rebase

✅ Branch has been successfully rebased

phlogistonjohn
phlogistonjohn approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Apr 30, 2025
@mergify
Merge of #1106
6e16cc5
@mergify mergify bot mentioned this pull request Apr 30, 2025
Closed
59 tasks
@mergify mergify bot merged commit 0db2316 into ceph:master Apr 30, 2025
16 checks passed
@anoopcs9 anoopcs9 deleted the add-tentacle-ci branch April 30, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees

No one assigned

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anoopcs9 @phlogistonjohn