rbd: add support for CloneImageByID() #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Early feedback: can you please name the file after the feature and not a ceph version. This has caused confusion in the past (literally yesterday in #999) and isn't strictly needed. Something like |
cdb01f3 to
4596b70
Compare
Member
Author
|
Tests seem to run in squid and main: |
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Jun 24, 2024
The new rbd_clone4() API is only available in Squid and newer. Squid is not yet released, therefor it is required to use the container image from the Ceph CI registry. rbd_clone() is added in PR ceph/go-ceph#1000, that branch needs to be vendored as well.
phlogistonjohn
requested changes
Jun 24, 2024
Collaborator
phlogistonjohn
left a comment
There was a problem hiding this comment.
Minor typo, code generally looks ok.
6c99adc to
1d1bac3
Compare
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Jun 25, 2024
The new rbd_clone4() API is only available in Squid and newer. Squid is not yet released, therefor it is required to use the container image from the Ceph CI registry. rbd_clone() is added in PR ceph/go-ceph#1000, that branch needs to be vendored as well.
anoopcs9
reviewed
Jun 25, 2024
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Jun 25, 2024
The new rbd_clone4() API is only available in Squid and newer. Squid is not yet released, therefor it is required to use the container image from the Ceph CI registry. rbd_clone() is added in PR ceph/go-ceph#1000, that branch needs to be vendored as well.
RBD image groups can be used to create consistent snapshots of all images that are part of the group. The new rbd_clone4() API makes it possible to create a new RBD image from a single snapshot that was created as part of the group snapshot. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBD image groups can be used to create consistent snapshots of all images that are part of the group. The new rbd_clone4() API makes it possible to create a new RBD image from a single snapshot that was created as part of the group snapshot.
Note about testing status
The
rbd_clone4()API has only just been backported to Squid for version 19.1.1. There are no released container images available yet that contain this new API, only theceph-ci/ceph:mainimage seems to have it.Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.