rbd: enable WholeObject & IncludeParent in snap diff#6279
Merged
Conversation
Contributor
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
a806782 to
b5a7f5a
Compare
Madhu-1
approved these changes
May 18, 2026
iPraveenParihar
approved these changes
May 19, 2026
Contributor
|
Adding skip/e2e label since we don't have e2e for this Today. |
Contributor
|
Deprecation notice: This pull request comes from a fork and was queued with |
Contributor
Merge Queue Status
This pull request spent 5 hours 49 minutes 42 seconds in the queue, including 5 hours 48 minutes 59 seconds running CI. Required conditions to merge
|
Enable WholeObject and IncludeParent flags in DiffIterateByIDConfig used by ProcessMetadata, matching the existing DiffIterate config in getUsedBytes. WholeObject improves performance by reporting whole-object granularity diffs instead of byte-level diffs. IncludeParent ensures diffs against parent snapshots are included. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Rakshith R <rar@redhat.com>
b5a7f5a to
b999c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable WholeObject and IncludeParent flags in DiffIterateByIDConfig
used by ProcessMetadata, matching the existing DiffIterate config
in getUsedBytes. WholeObject improves performance by reporting
whole-object granularity diffs instead of byte-level diffs.
IncludeParent ensures diffs against parent snapshots are included.
Assisted-by: Claude noreply@anthropic.com