Skip to content

cephfs: add RBAC for VolumeGroupReplication resources#6233

Merged
mergify[bot] merged 1 commit into
ceph:develfrom
iPraveenParihar:cephfs/add-missing-rbacs
Apr 14, 2026
Merged

cephfs: add RBAC for VolumeGroupReplication resources#6233
mergify[bot] merged 1 commit into
ceph:develfrom
iPraveenParihar:cephfs/add-missing-rbacs

Conversation

@iPraveenParihar

@iPraveenParihar iPraveenParihar commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Describe what this PR does

The vgrcontent-controller needs access to VolumeGroupReplicationContent and 
VolumeGroupReplicationClass resources. Add the required ClusterRole rules to
the CephFS provisioner RBAC in both deploy manifests and Helm chart. Since we
added the omap-controller sidecar to CephFS deployoment.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar
cephfs: add RBAC for VolumeGroupReplication resources
b24dce9 
The vgrcontent-controller needs access to
VolumeGroupReplicationContent and VolumeGroupReplicationClass
resources. Add the required ClusterRole rules to the CephFS
provisioner RBAC in both deploy manifests and Helm chart. Since
we added the omap-controller sidecar to CephFS deployoment.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@mergify mergify Bot added the component/cephfs Issues related to CephFS label Apr 14, 2026
@iPraveenParihar iPraveenParihar marked this pull request as ready for review April 14, 2026 03:51
@iPraveenParihar iPraveenParihar mentioned this pull request Apr 14, 2026
Merged
6 tasks
@iPraveenParihar iPraveenParihar requested a review from a team April 14, 2026 06:25
@iPraveenParihar

iPraveenParihar commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio rebase

@mergify

mergify Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@nixpanic nixpanic added the ci/skip/e2e skip running e2e CI jobs label Apr 14, 2026
@nixpanic

nixpanic commented Apr 14, 2026

Copy link
Copy Markdown
Member

We don't have e2e tests for VolumeGroupReplication, no need to run them.

@iPraveenParihar

iPraveenParihar commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify

mergify Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Deprecation notice: This pull request comes from a fork and was queued with update_method=rebase and update_bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the merge queue will no longer be able to rebase fork pull requests with this configuration. To avoid disruption, switch to update_method=merge in your queue rule.

@mergify

mergify Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-04-14 06:54 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-04-14 06:55 UTC · at b24dce90bf6877a888a3b57fb4bd59b24280d3e0

This pull request spent 7 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify Bot merged commit c70029d into ceph:devel Apr 14, 2026
23 checks passed
@mergify

mergify Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

🛑 Queue command has been cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nikhil-Ladha Nikhil-Ladha Nikhil-Ladha approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

No one assigned

Labels

ci/skip/e2e skip running e2e CI jobs component/cephfs Issues related to CephFS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iPraveenParihar @nixpanic @Nikhil-Ladha @Rakshith-R