Skip to content

nvmeof: make nvmeofGatewayPort an optional StorageClass parameter#6230

Merged
mergify[bot] merged 2 commits into
ceph:develfrom
nixpanic:nvmeof/optional-nvmeofGatewayPort
Apr 13, 2026
Merged

nvmeof: make nvmeofGatewayPort an optional StorageClass parameter#6230
mergify[bot] merged 2 commits into
ceph:develfrom
nixpanic:nvmeof/optional-nvmeofGatewayPort

Conversation

@nixpanic

@nixpanic nixpanic commented Apr 13, 2026

Copy link
Copy Markdown
Member

The nvmeofGatewayPort parameter in the StorageClass is now optional. When not
provided, the NVMe-oF gateway management API port defaults to 5500. The default
is applied in NewGatewayRpcClient when Port is 0, keeping the default out of
the controller layer.

@nixpanic nixpanic requested a review from gadididi April 13, 2026 10:08
@mergify mergify Bot added the component/nvme-of Issues and PRs related to NVMe-oF. label Apr 13, 2026
@nixpanic nixpanic force-pushed the nvmeof/optional-nvmeofGatewayPort branch 3 times, most recently from 989af90 to cbc02f4 Compare April 13, 2026 11:34
@nixpanic nixpanic requested a review from a team April 13, 2026 11:52
gadididi
gadididi approved these changes Apr 13, 2026
View reviewed changes

@gadididi gadididi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@nixpanic

nixpanic commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

nixpanic added 2 commits April 13, 2026 16:32
@nixpanic @ceph-csi-bot
nvmeof: make nvmeofGatewayPort an optional StorageClass parameter
2f2608a 
The nvmeofGatewayPort parameter in the StorageClass is now optional.
When not provided, the NVMe-oF gateway management API port defaults to
5500. The default is applied in NewGatewayRpcClient when Port is 0,
keeping the default out of the controller layer.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic @ceph-csi-bot
nvmeof: update unit test for optional nvmeofGatewayPort
8fa4605 
Update TestGetGatewayConfigFromRequest to reflect that nvmeofGatewayPort
is now optional: the address-only case now succeeds and expects Port=0
(the default is applied later by NewGatewayRpcClient). Test cases are
named for clarity and run in parallel.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@ceph-csi-bot ceph-csi-bot force-pushed the nvmeof/optional-nvmeofGatewayPort branch from cbc02f4 to 8fa4605 Compare April 13, 2026 16:32
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Apr 13, 2026
@mergify

mergify Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify

mergify Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot

ceph-csi-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot ceph-csi-bot added ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. and removed ok-to-test Label to trigger E2E tests labels Apr 13, 2026
@mergify mergify Bot removed the ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. label Apr 13, 2026
@mergify

mergify Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Deprecation notice: This pull request comes from a fork and was queued with update_method=rebase and update_bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the merge queue will no longer be able to rebase fork pull requests with this configuration. To avoid disruption, switch to update_method=merge in your queue rule.

@mergify

mergify Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-04-13 19:48 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-04-13 19:49 UTC · at 8fa4605ee36975da7cf93e28aba79a4bc4450ae5

This pull request spent 37 seconds in the queue, including 6 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit 8bea212 into ceph:devel Apr 13, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@gadididi gadididi gadididi approved these changes

Assignees

No one assigned

Labels

cleanup component/nvme-of Issues and PRs related to NVMe-oF.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nixpanic @ceph-csi-bot @Madhu-1 @gadididi