cleanup: deprecate the setmetadata flag by iPraveenParihar · Pull Request #6225 · ceph/ceph-csi

iPraveenParihar · 2026-04-07T09:52:42Z

Describe what this PR does

The `--setmetadata` flag has been enabled by default and metadata
is always set on volumes. Remove the flag, its Config struct field,
and all related from the core configuration.

Fixes: #5433

Checklist:

Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
Reviewed the developer guide on Submitting a Pull Request
Pending release notes updated with breaking and/or notable changes for the next major release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)

iPraveenParihar · 2026-04-07T15:30:04Z

/test ci/centos/mini-e2e/k8s-1.35

iPraveenParihar · 2026-04-08T04:44:06Z

/test ci/centos/mini-e2e/k8s-1.35

nixpanic · 2026-04-08T08:59:24Z

Has the flag been removed from ceph-csi-operator too already?

iPraveenParihar · 2026-04-08T09:29:07Z

Has the flag been removed from ceph-csi-operator too already?

Not yet, will be removed after we remove from ceph-csi right?

nixpanic · 2026-04-08T12:48:16Z

Has the flag been removed from ceph-csi-operator too already?

Not yet, will be removed after we remove from ceph-csi right?

If we remove it, ceph-csi-operator deployments will still have the parameter and the containers will fail to start.

We need the change in ceph-csi-operator first, otherwise our e2e will fail (k8s-external-storage deploys with ceph-csi-operator).

Madhu-1 · 2026-04-09T06:32:02Z

@iPraveenParihar i think we should not remove it rather add a log stating that setting the field will have no effect so that we dont break any clusters

iPraveenParihar · 2026-04-09T07:28:11Z

@iPraveenParihar i think we should not remove it rather add a log stating that setting the field will have no effect so that we dont break any clusters

Okay, we can remove the flag in two-phases?

This release: Keep the flag, make it a no-op, and log a deprecation warning.
Next release: Remove the flag entirely.

Madhu-1 · 2026-04-09T09:07:19Z

@iPraveenParihar i think we should not remove it rather add a log stating that setting the field will have no effect so that we dont break any clusters

Okay, we can remove the flag in two-phases?

This release: Keep the flag, make it a no-op, and log a deprecation warning.

Next release: Remove the flag entirely.

yes that would be good plan

mergify · 2026-04-09T10:21:43Z

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

iPraveenParihar · 2026-04-10T07:31:43Z

/test ci/centos/mini-e2e/k8s-1.35

iPraveenParihar · 2026-04-13T08:16:42Z

@nixpanic @Madhu-1 PTAL

mergify · 2026-04-14T10:48:08Z

rebase

✅ Branch has been successfully rebased

nixpanic · 2026-04-14T11:17:48Z

Use @mergifyio rebase to do a rebase once #6232 is merged. After rebasing, add the ok-to-test label to run CI and get this PR merged.

nixpanic · 2026-04-14T17:41:27Z

@Mergifyio rebase

Remove the SetMetadata/EnableMetadata fields and conditional checks from the RBD driver. Metadata is now always set on volumes. Signed-off-by: Praveen M <m.praveen@ibm.com>

Remove the SetMetadata/enableMetadata fields, parameters, and conditional checks from the CephFS driver, core, and store packages. Metadata is now always set on volumes. Signed-off-by: Praveen M <m.praveen@ibm.com>

The `--setmetadata` flag has been enabled by default and metadata is always set on volumes. deprecate the flag, its Config struct field, and all related from the core configuration. Signed-off-by: Praveen M <m.praveen@ibm.com>

Mark the `--setmetadata` flag as deprecated in the RBD and CephFS deployment documentation tables. Signed-off-by: Praveen M <m.praveen@ibm.com>

The `setmetadata` flag has been deprecated as metadata is now always set on images and subvolumes. Remove the `setEnableMetadata` methods and the test that verified behavior. Signed-off-by: Praveen M <m.praveen@ibm.com>

Signed-off-by: Praveen M <m.praveen@ibm.com>

mergify · 2026-04-14T17:41:59Z

rebase

✅ Branch has been successfully rebased

ceph-csi-bot · 2026-04-14T17:42:02Z

/test ci/centos/k8s-e2e-external-storage/1.34

ceph-csi-bot · 2026-04-14T17:42:02Z

/test ci/centos/k8s-e2e-external-storage/1.35

ceph-csi-bot · 2026-04-14T17:42:02Z

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot · 2026-04-14T17:42:03Z

/test ci/centos/mini-e2e-helm/k8s-1.34

ceph-csi-bot · 2026-04-14T17:42:03Z

/test ci/centos/mini-e2e-helm/k8s-1.35

ceph-csi-bot · 2026-04-14T17:42:03Z

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot · 2026-04-14T17:42:04Z

/test ci/centos/mini-e2e/k8s-1.34

ceph-csi-bot · 2026-04-14T17:42:04Z

/test ci/centos/mini-e2e/k8s-1.35

ceph-csi-bot · 2026-04-14T17:42:04Z

/test ci/centos/k8s-e2e-external-storage/1.33

ceph-csi-bot · 2026-04-14T17:42:04Z

/test ci/centos/mini-e2e-helm/k8s-1.33

ceph-csi-bot · 2026-04-14T17:42:05Z

/test ci/centos/mini-e2e/k8s-1.33

mergify · 2026-04-14T21:03:13Z

Deprecation notice: This pull request comes from a fork and was queued with update_method=rebase and update_bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the merge queue will no longer be able to rebase fork pull requests with this configuration. To avoid disruption, switch to update_method=merge in your queue rule.

mergify · 2026-04-14T21:03:16Z

Merge Queue Status

✅ Entered queue — 2026-04-14 21:03 UTC · Rule: default
✅ Checks skipped · PR is already up-to-date
✅ Merged — 2026-04-14 21:03 UTC · at ebc6b889129ec8f7f80ab57c03909a8957911b30

This pull request spent 12 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

#approved-reviews-by >= 2 [🛡 GitHub branch protection]
- cleanup: deprecate the setmetadata flag #6225
#changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
- cleanup: deprecate the setmetadata flag #6225

mergify Bot added the cleanup label Apr 7, 2026

iPraveenParihar mentioned this pull request Apr 7, 2026

e2e: add setEnableFencing for operator deployment #6221

Closed

6 tasks

iPraveenParihar force-pushed the cleanup-remove-setmetadata-flag branch 6 times, most recently from e40c136 to 74828d4 Compare April 7, 2026 15:29

iPraveenParihar force-pushed the cleanup-remove-setmetadata-flag branch from 74828d4 to ac637b9 Compare April 8, 2026 04:43

iPraveenParihar marked this pull request as ready for review April 8, 2026 09:41

iPraveenParihar force-pushed the cleanup-remove-setmetadata-flag branch from ac637b9 to e989738 Compare April 9, 2026 10:17

iPraveenParihar force-pushed the cleanup-remove-setmetadata-flag branch 2 times, most recently from a302d93 to 776ad3e Compare April 10, 2026 07:07

iPraveenParihar requested review from Rakshith-R and nixpanic April 10, 2026 11:00

nixpanic approved these changes Apr 14, 2026

View reviewed changes

nixpanic requested a review from a team April 14, 2026 08:15

nixpanic added component/cephfs Issues related to CephFS component/rbd Issues related to RBD labels Apr 14, 2026

iPraveenParihar added 6 commits April 14, 2026 17:41

rbd: remove setmetadata flag usage

c2260e8

Remove the SetMetadata/EnableMetadata fields and conditional checks from the RBD driver. Metadata is now always set on volumes. Signed-off-by: Praveen M <m.praveen@ibm.com>

cephfs: remove setmetadata flag usage

1cf1f8a

Remove the SetMetadata/enableMetadata fields, parameters, and conditional checks from the CephFS driver, core, and store packages. Metadata is now always set on volumes. Signed-off-by: Praveen M <m.praveen@ibm.com>

cleanup: deprecate the setmetadata flag from configuration

cdb7c8f

The `--setmetadata` flag has been enabled by default and metadata is always set on volumes. deprecate the flag, its Config struct field, and all related from the core configuration. Signed-off-by: Praveen M <m.praveen@ibm.com>

docs: deprecate --setmetadata flag in deployment docs

7df22a4

Mark the `--setmetadata` flag as deprecated in the RBD and CephFS deployment documentation tables. Signed-off-by: Praveen M <m.praveen@ibm.com>

e2e: remove setmetadata flag related tests

69c963e

The `setmetadata` flag has been deprecated as metadata is now always set on images and subvolumes. Remove the `setEnableMetadata` methods and the test that verified behavior. Signed-off-by: Praveen M <m.praveen@ibm.com>

doc: add release note for --setmetadata flag removal

ebc6b88

Signed-off-by: Praveen M <m.praveen@ibm.com>

ceph-csi-bot force-pushed the cleanup-remove-setmetadata-flag branch from 82aa312 to ebc6b88 Compare April 14, 2026 17:41

nixpanic added the ok-to-test Label to trigger E2E tests label Apr 14, 2026

ceph-csi-bot added ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. and removed ok-to-test Label to trigger E2E tests labels Apr 14, 2026

mergify Bot removed the ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. label Apr 14, 2026

mergify Bot merged commit d6f0ea8 into ceph:devel Apr 14, 2026
41 checks passed

iPraveenParihar mentioned this pull request Apr 17, 2026

deprecate: driver.spec.EnableMetadata field ceph/ceph-csi-operator#454

Merged

6 tasks

Conversation

iPraveenParihar commented Apr 7, 2026

Describe what this PR does

Uh oh!

iPraveenParihar commented Apr 7, 2026

Uh oh!

iPraveenParihar commented Apr 8, 2026

Uh oh!

nixpanic commented Apr 8, 2026

Uh oh!

iPraveenParihar commented Apr 8, 2026

Uh oh!

nixpanic commented Apr 8, 2026

Uh oh!

Madhu-1 commented Apr 9, 2026

Uh oh!

iPraveenParihar commented Apr 9, 2026

Uh oh!

Madhu-1 commented Apr 9, 2026

Uh oh!

mergify Bot commented Apr 9, 2026

Uh oh!

iPraveenParihar commented Apr 10, 2026

Uh oh!

iPraveenParihar commented Apr 13, 2026

Uh oh!

mergify Bot commented Apr 14, 2026

✅ Branch has been successfully rebased

Uh oh!

nixpanic commented Apr 14, 2026

Uh oh!

nixpanic commented Apr 14, 2026

Uh oh!

mergify Bot commented Apr 14, 2026

✅ Branch has been successfully rebased

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

ceph-csi-bot commented Apr 14, 2026

Uh oh!

mergify Bot commented Apr 14, 2026

Uh oh!

mergify Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mergify Bot commented Apr 14, 2026 •

edited

Loading