e2e: add setEnableFencing for operator deployment#6221
Closed
iPraveenParihar wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
/test ci/centos/mini-e2e-operator/k8s-1.35 |
Add setEnableFencing to the DeploymentMethod interface with a default no-op on DriverInfo for template-based deployments. OperatorDeployment overrides it to patch the operator config (spec.driverSpecDefaults.enableFencing). Signed-off-by: Praveen M <m.praveen@ibm.com>
ec33496 to
973122b
Compare
Contributor
Author
|
/test ci/centos/mini-e2e-operator/k8s-1.35 |
Contributor
Author
Member
|
there is a similar commit in #5672 for this |
Contributor
Author
|
Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Add setEnableFencing to the DeploymentMethod interface with a default no-op on DriverInfo for template-based deployments. OperatorDeployment overrides it to patch the operator config (spec.driverSpecDefaults.enableFencing).
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)