rbd: use StorageClass image features for temp clones and snapshots#6205
Conversation
518136f to
95b5c6b
Compare
|
/test ci/centos/mini-e2e/k8s-1.35 |
nixpanic
left a comment
There was a problem hiding this comment.
LGTM. Does it make sense to add an e2e test for this?
Would be useful to backport this as a bugfix to previous releases?
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
Pull request has been modified.
Added e2e test. |
| err = validateImageFeatures(f, tempCloneImageName, defaultRBDPool, expectedFeatures) | ||
| if err != nil { | ||
| logAndFail("temp clone image %s features validation failed: %v", | ||
| tempCloneImageName, err) |
There was a problem hiding this comment.
[FAILED] temp clone image csi-vol-a6dbc189-e6d1-4120-8599-d2db25a8ff8c-temp features validation failed: failed to get rbd info: failed to execute command: command terminated with exit code 2
unfortunately this failed
There was a problem hiding this comment.
Errno 2: ENOENT: No such file or directory
There was a problem hiding this comment.
Ahh, it should be
imageData, err := getImageInfoFromPVC(pvcSmartClone.Namespace, pvcSmartClone.Name, f)
There was a problem hiding this comment.
e2e passed now. PTAL
Thanks!
705735b to
552b36e
Compare
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
@Rakshith-R @nixpanic PTAL. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
552b36e to
b3d3c57
Compare
|
@Mergifyio rebase |
b3d3c57 to
cfe2178
Compare
✅ Branch has been successfully rebased |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/mini-e2e/k8s-1.33 |
Merge Queue Status
This pull request spent 3 hours 17 minutes 52 seconds in the queue, including 3 hours 17 minutes 21 seconds running CI. Required conditions to merge
|
Previously, temporary clone images (-temp) and snapshot backing images had their features hard-coded to only layering and deep-flatten. Inherit the image features from the parent volume (configured via StorageClass imageFeatures) while ensuring layering and deep-flatten are always enabled, as they are required for the flatten operation. Signed-off-by: Praveen M <m.praveen@ibm.com>
Add an e2e test that verifies the intermediate RBD images created during snapshot and clone operations inherit StorageClass image features. Specifically validates: - csi-snap-* (snapshot backing image) inherits features from parent - csi-vol-*-temp (temp clone image) inherits features from parent Signed-off-by: Praveen M <m.praveen@ibm.com>
79f17ee to
70fd4d1
Compare
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
/test ci/centos/mini-e2e/k8s-1.33 |
Describe what this PR does
Fixes: #4936
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)