Skip to content

e2e: convert By() to It() and use Ordered containers#6136

Merged
mergify[bot] merged 1 commit into
ceph:develfrom
Rakshith-R:e2e-beforeAll
Mar 11, 2026
Merged

e2e: convert By() to It() and use Ordered containers#6136
mergify[bot] merged 1 commit into
ceph:develfrom
Rakshith-R:e2e-beforeAll

Conversation

@Rakshith-R

@Rakshith-R Rakshith-R commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe what this PR does

Convert top-level By() test steps to individual It()
specs so each step runs as a separate spec.

Add Ordered decorator to Context/Describe containers.

Add OncePerOrdered to BeforeEach/AfterEach
so setup and teardown run just once.

Move metadataPool lookup BeforeEach(OncePerOrdered).
Add "AfterAll" to the codespell ignore list.
Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify Bot added the component/testing Additional test cases or CI work label Feb 26, 2026
@Rakshith-R

Rakshith-R commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R

Rakshith-R commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.35

@Rakshith-R

Rakshith-R commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R

Rakshith-R commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R

Rakshith-R commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R

Rakshith-R commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R

Rakshith-R commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35/rbd

@Rakshith-R

Rakshith-R commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35/cephfs

@Rakshith-R

Rakshith-R commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@nixpanic

nixpanic commented Mar 4, 2026

Copy link
Copy Markdown
Member

@Mergifyio rebase

@mergify

mergify Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@nixpanic

nixpanic commented Mar 4, 2026

Copy link
Copy Markdown
Member

@Mergifyio rebase

Oh, too early, #6138 is not merged yet.

@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Mar 4, 2026
@Rakshith-R

Rakshith-R commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio rebase

@mergify

mergify Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@Rakshith-R

Rakshith-R commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R

Rakshith-R commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.35

@Rakshith-R Rakshith-R changed the title e2e: use BeforeAll/AfterAll and convert By() to It() e2e: convert By() to It() and use Ordered containers Mar 5, 2026
@Rakshith-R

Rakshith-R commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.35

@nixpanic

nixpanic commented Mar 10, 2026

Copy link
Copy Markdown
Member

@Mergifyio rebase

@Rakshith-R @ceph-csi-bot
e2e: convert By() to It() and use Ordered containers
d120f66 
Convert top-level By() test steps to individual It()
specs so each step runs as a separate spec.

Add Ordered decorator to Context/Describe containers.

Add OncePerOrdered to BeforeEach/AfterEach
so setup and teardown run just once.

Move metadataPool lookup BeforeEach(OncePerOrdered).
Add "AfterAll" to the codespell ignore list.

Signed-off-by: Rakshith R <rar@redhat.com>
@mergify

mergify Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@nixpanic

nixpanic commented Mar 10, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

Does this add the ok-to-test label automatically?

@mergify

mergify Bot commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

🛑 Queue command has been cancelled

@nixpanic

nixpanic commented Mar 10, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

Does this add the ok-to-test label automatically?

no, it does not.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Mar 10, 2026
@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 10, 2026
@Rakshith-R

Rakshith-R commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio rebase

@mergify

mergify Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@Rakshith-R

Rakshith-R commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest ci/centos/mini-e2e-helm/k8s-1.34

@Rakshith-R

Rakshith-R commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest ci/centos/mini-e2e-helm/k8s-1.35

@Rakshith-R

Rakshith-R commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest ci/centos/k8s-e2e-external-storage

@mergify mergify Bot added the queued label Mar 11, 2026
@mergify mergify Bot merged commit 5a35009 into ceph:devel Mar 11, 2026
41 of 43 checks passed
@mergify

mergify Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-03-11 04:40 UTC · Rule: default
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-03-11 04:40 UTC · at d120f66a8ae933e352956a4bb90cd73321d033d8

This pull request spent 8 seconds in the queue, with no time running CI.

Required conditions to merge

@mergify mergify Bot removed the queued label Mar 11, 2026
@iPraveenParihar iPraveenParihar mentioned this pull request Apr 2, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees

No one assigned

Labels

ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rakshith-R @nixpanic @ceph-csi-bot @Madhu-1