e2e: enable fail-fast to abort suite on first test failure#6088
Merged
Conversation
Configure Ginkgo's FailFast option so that when any spec fails, all remaining specs are skipped immediately instead of continuing to run the rest of the suite. Signed-off-by: Rakshith R <rar@redhat.com>
Contributor
Author
|
/test ci/centos/mini-e2e/k8s-1.34 |
890b29c to
e4e615e
Compare
Contributor
Author
|
/test ci/centos/mini-e2e/k8s-1.34/rbd |
Madhu-1
approved these changes
Feb 18, 2026
Member
|
Have you considered passing |
Contributor
Author
We anyway need all testcases to pass to merge pr, therefore it makes sense to enable it by default in code ? The functionality is the same but it would again scatter the configurations IMO. |
nixpanic
approved these changes
Feb 19, 2026
Member
|
@Mergifyio queue |
Contributor
Merge Queue StatusRule:
This pull request spent 2 hours 49 minutes 40 seconds in the queue, including 2 hours 49 minutes 30 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
78 tasks
Contributor
Author
failed due to ci flake adding skip-ci label. |
Contributor
Author
|
@Mergifyio requeue |
Contributor
Merge Queue StatusRule:
This pull request spent 1 hour 36 minutes 35 seconds in the queue, including 5 minutes 14 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Configure Ginkgo's FailFast option so that when any spec fails,
all remaining specs are skipped immediately instead of continuing
to run the rest of the suite.
Saves a lot of ci resources.
Example run
https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.34/detail/mini-e2e_k8s-1.34/567/pipeline/
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)