rbd: fix missing data pool#6086
Conversation
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
|
@iPraveenParihar i have added complete E2E testing for EC #6087 please feel free to pick that changes and run on top of this to verify everything works |
d15c81f to
752395a
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
752395a to
56b034f
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
56b034f to
1415a5e
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
1415a5e to
0d3f17a
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
0d3f17a to
d12faca
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
d12faca to
f59d806
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
@Madhu-1 the e2e has passed! |
| } | ||
|
|
||
| // getDataPoolID returns the data pool ID for the RBD image. | ||
| // For images with erasure-coded data pools, this returns the ID of the pool |
There was a problem hiding this comment.
| // For images with erasure-coded data pools, this returns the ID of the pool | |
| // For an image with an erasure-coded data pool, this returns the ID of the pool |
| // populateDataPool retrieves and sets the data pool name for erasure-coded volumes. | ||
| // For images with a separate data pool (e.g., erasure-coded pools), this ensures | ||
| // the DataPool field is populated so that clones and snapshots preserve the data | ||
| // pool configuration. Errors are logged but not returned as this is non-fatal. |
There was a problem hiding this comment.
| // populateDataPool retrieves and sets the data pool name for erasure-coded volumes. | |
| // For images with a separate data pool (e.g., erasure-coded pools), this ensures | |
| // the DataPool field is populated so that clones and snapshots preserve the data | |
| // pool configuration. Errors are logged but not returned as this is non-fatal. | |
| // populateDataPool retrieves and sets the data pool name for erasure-coded volume. | |
| // For image with a separate data pool (e.g., erasure-coded pool), this ensures | |
| // the DataPool field is populated so that clone and snapshot preserve the data | |
| // pool configuration. Errors are logged but not returned as this is non-fatal. |
| return | ||
| } | ||
|
|
||
| if dataPoolID == util.InvalidPoolID { |
There was a problem hiding this comment.
When will this be reached? i assume this will happen for the replicated pool, if yes please add a comment about this check
f59d806 to
9f003db
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
|
/test ci/centos/mini-e2e/k8s-1.35 |
| // For image with a separate data pool (e.g., erasure-coded pool), this ensures | ||
| // the DataPool field is populated so that clone and snapshot preserve the data | ||
| // pool configuration. Errors are logged but not returned as this is non-fatal. | ||
| func (rv *rbdVolume) populateDataPool(ctx context.Context, cr *util.Credentials) { |
There was a problem hiding this comment.
good to return an error from this function and handle it at the caller
09e9e41 to
24ba2d3
Compare
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/mini-e2e/k8s-1.33 |
This commit adds populateDataPool() to retrieve the data pool from the source RBD image, ensuring the data pool is present in snapshot image. Signed-off-by: Praveen M <m.praveen@ibm.com>
This PR adds the E2E testing to clone from replicapool to EC pool and from EC pool to replicapool and validates the images are created in the right pool. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 8ba6ffb) Signed-off-by: Praveen M <m.praveen@ibm.com>
559cb1c to
e7aaf2e
Compare
Merge Queue Status
This pull request spent 2 hours 49 minutes 58 seconds in the queue, including 2 hours 49 minutes 40 seconds running CI. Required conditions to merge
|
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/mini-e2e/k8s-1.33 |
☑️ This pull request is already queued |
Describe what this PR does
Problem:
This commit adds populateDataPool() to retrieve the data pool
from the source RBD image, ensuring the data pool is present
in snapshot image.
Fixes: #4761
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)