rebase: bump github.com/ceph/ceph-nvmeof/lib/go/nvmeof#5947
Merged
Conversation
Bumps to the devel latest. proto file in nvmeof repo has been updated. dh-chap controlelr key was added to AddHost grpc. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
Madhu-1
previously approved these changes
Jan 20, 2026
156f4c4 to
14865c2
Compare
Due to there is no offical NVMe-oF releaser with AutoListener feature proto file was changed lately and make networkMask to be list of string. because this commit in bumping PR, I made the the least of changes. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
14865c2 to
9f5bca2
Compare
nixpanic
approved these changes
Jan 20, 2026
nixpanic
left a comment
Member
There was a problem hiding this comment.
Is there a new release of the gateway that has the new API?
Contributor
Author
|
@nixpanic , yes there is |
Madhu-1
approved these changes
Jan 21, 2026
Collaborator
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 0db8e21 |
Contributor
Merge Queue Status✅ The pull request has been merged at 9f5bca2 This pull request spent 34 minutes 59 seconds in the queue, including 34 minutes 43 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto file in the nvmeof repo has been updated.
Bump due to AddHost command now can get controller dh-chap key. and it must be for this PR:
#5913
There is little change in nvmeof.go file
Due to there is no offical NVMe-oF releaser with AutoListener feature proto file was changed lately and make networkMask to be list of string. Because this commit in bumping PR, I made the the least of changes.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)