Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

build-push-ceph-container-imgs.sh: do not overwrite images created fo…#1712

Merged
tchaikov merged 1 commit intoceph:masterfrom
tchaikov:wip-no-overwrite
Jul 17, 2020
Merged

build-push-ceph-container-imgs.sh: do not overwrite images created fo…#1712
tchaikov merged 1 commit intoceph:masterfrom
tchaikov:wip-no-overwrite

Conversation

@tchaikov
Copy link
Contributor

…r default flavor

otherwise cephadm and other consumers pulling using $full_repo_tag,
$branch_repo_tag and $sha1_repo_tag will be testing crimson-osd, if
crimson-osd flavored image is pushed after the default one.

Signed-off-by: Kefu Chai kchai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.

…r default flavor

otherwise cephadm and other consumers pulling using $full_repo_tag,
$branch_repo_tag and $sha1_repo_tag will be testing crimson-osd, if
crimson-osd flavored image is pushed after the default one.

this change addresses a regression introduced by 3b59e10

Fixes: ceph#1712
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Jul 17, 2020

cc @ideepika , @sebastian-philipp

@tchaikov tchaikov merged commit db47094 into ceph:master Jul 17, 2020
@tchaikov tchaikov deleted the wip-no-overwrite branch July 17, 2020 18:10
@sebastian-philipp
Copy link
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants