common: Register local docker.io registry mirror#591
common: Register local docker.io registry mirror#591sebastian-philipp wants to merge 1 commit intoceph:masterfrom
Conversation
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
|
cc @tchaikov |
| name: git+https://github.com/sebastian-philipp/registries-conf-ctl | ||
|
|
||
| - name: Add local docker.io registry mirror | ||
| command: registries-conf-ctl add-mirror docker.io docker-mirror.front.sepia.ceph.com |
There was a problem hiding this comment.
Is :5000 required or is that assumed?
There was a problem hiding this comment.
I'd be super glad, if you could take over this PR. As I said, I have close to no expertise in ansible playbooks.
There was a problem hiding this comment.
May I suggest two tasks?
- name: Add local docker.io registry mirror | docker
command: registries-conf-ctl --conf=/etc/docker/daemon.json add-mirror docker.io docker-mirror.front.sepia.ceph.com:5000
when:
- check_for_docker is success
- check_for_podman is not success
- name: Add local docker.io registry mirror | podman
command: registries-conf-ctl --conf=/etc/containers/registries.conf add-mirror docker.io docker-mirror.front.sepia.ceph.com:5000
when:
- check_for_docker is not success
- check_for_podman is success
There was a problem hiding this comment.
support for docker is not yet implemented in registries-conf-ctl. let me have a look....
There was a problem hiding this comment.
support for docker is not yet implemented in registries-conf-ctl. let me have a look....
If you can handle this portion, I'd be happy to handle the ceph-cm-ansible changes.
There was a problem hiding this comment.
https://github.com/sebastian-philipp/registries-conf-ctl#registries-conf-ctl now supports also the daemon.json.
registries-conf-ctl add-mirror docker.io docker-mirror.front.sepia.ceph.com:5000
should now work for podman and docker
There was a problem hiding this comment.
How does your tool work? I can't read python so I'm going to ask dumb questions...
If docker and podman commands are both detected, will the tool modify both config files? What if neither are detected? Does it care? Will it create the files?
There was a problem hiding this comment.
guess it needs some more docs.
If docker and podman commands are both detected, will the tool modify both config files?
yes
What if neither are detected?
It will fail.
Will it create the files?
no
|
@djgalloway I suppose this will address the rate limiting issue: https://tracker.ceph.com/issues/48157, if do you know a way to add temporary fix for teuthology config, to change registry server? |
Sebastian's tool doesn't work on python2 distros yet though. sebastian-philipp/registries-conf-ctl#1 (comment) |
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Note that I'm not super familiar with ansible nor ceph-cm-ansible.
Take this as an idea or suggestion, instead of an actual PR.