Move container tasks to separate role#595
Merged
djgalloway merged 1 commit intomasterfrom Dec 3, 2020
Merged
Conversation
| when: usr_local_bin_rcc.stat.exists | ||
|
|
||
| - name: Add local docker.io registry mirror | ||
| command: "{{ rcc_path }} --conf={{ container_service_conf }} add-mirror docker.io {{ container_mirror }}" |
There was a problem hiding this comment.
Suggested change
| command: "{{ rcc_path }} --conf={{ container_service_conf }} add-mirror docker.io {{ container_mirror }}" | |
| command: "{{ rcc_path }} add-mirror docker.io {{ container_mirror }}" |
There should not be a need to specify the config anymore.
Contributor
Author
There was a problem hiding this comment.
If both exist, will they get modified?
Contributor
Author
There was a problem hiding this comment.
Something's still off then. This was on an Ubuntu 16.04 machine with docker.io installed. It shouldn't be looking for /etc/containers/registries.conf
TASK [container-host : Add local docker.io registry mirror] ********************************************************************************************************************************************************************************************************************
task path: /home/dgalloway/git/ceph/ceph-cm-ansible/roles/container-host/tasks/container_mirror.yml:53
changed: [gibba036.front.sepia.ceph.com] => {
"changed": true,
"cmd": [
"/usr/local/bin/registries-conf-ctl",
"add-mirror",
"docker.io",
"docker-mirror.front.sepia.ceph.com:5000"
],
"delta": "0:00:00.069744",
"end": "2020-12-03 18:55:43.784405",
"invocation": {
"module_args": {
"_raw_params": "/usr/local/bin/registries-conf-ctl add-mirror docker.io docker-mirror.front.sepia.ceph.com:5000",
"_uses_shell": false,
"argv": null,
"chdir": null,
"creates": null,
"executable": null,
"removes": null,
"stdin": null,
"stdin_add_newline": true,
"strip_empty_ends": true,
"warn": true
}
},
"rc": 0,
"start": "2020-12-03 18:55:43.714661",
"stderr": "",
"stderr_lines": [],
"stdout": "Ex: [Errno 2] No such file or directory: '/etc/containers/registries.conf'",
"stdout_lines": [
"Ex: [Errno 2] No such file or directory: '/etc/containers/registries.conf'"
]
}
There was a problem hiding this comment.
jmolmo
reviewed
Dec 3, 2020
| pip: | ||
| name: git+https://github.com/sebastian-philipp/registries-conf-ctl | ||
| state: latest | ||
|
|
Member
There was a problem hiding this comment.
executable: pip3.3
Maybe this could avoid the search of the installed package ... just an idea
Contributor
Author
There was a problem hiding this comment.
We don't have pip3 on all our testnodes.
jmolmo
approved these changes
Dec 3, 2020
Member
jmolmo
left a comment
There was a problem hiding this comment.
LGTM. But i have not a good knowledge of the ceph testing labs. So i'm probably not the ideal one to detect collateral/unexpected effects.
I would've liked to keep all this in common but there's a chicken and egg situation. docker and/or podman get installed during the testnode role. The testnode role can only be run after the common role. The testnode role is also where some repos are added. So we need to install docker/podman and configure it after the testnodes role runs. Since we also want to be able to configure docker/podman on other systems, I couldn't put these tasks in the testnode role. Signed-off-by: David Galloway <dgallowa@redhat.com>
4de8646 to
72b6473
Compare
|
Still not working: @jmolmo any idea? |
Member
|
I think that the modification in the docker config file is done: But .. I cannot find any restart of the docker service.. so probably the new configuration is not used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would've liked to keep all this in the
commonrole but there's a chicken and egg situation.docker and/or podman get installed during the testnode role. The testnode role can only be run after the common role. The testnode role is also where some repos are added.
So we need to install docker/podman and configure it after the testnodes role runs. Since we also want to be able to configure docker/podman on other systems, I couldn't put these tasks in the testnode role.
Signed-off-by: David Galloway dgallowa@redhat.com