add WITH_BOOST_VALGRIND to default build flavor#2043
Merged
djgalloway merged 1 commit intoceph:mainfrom Aug 17, 2022
Merged
Conversation
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
cc @yuvalif @tchaikov @djgalloway i'm working with @mkogan1 to test whether we can observe any overhead from these builds. DNM pending those results |
tchaikov
approved these changes
Aug 3, 2022
Contributor
https://lists.ceph.io/hyperkitty/list/dev@ceph.io/message/ZGP75L3PJYETWKKW62FFPEFD2FY7MXXU/ |
idryomov
approved these changes
Aug 12, 2022
neha-ojha
approved these changes
Aug 17, 2022
Contributor
Author
|
yay, thanks everybody! |
cbodley
added a commit
to cbodley/ceph-build
that referenced
this pull request
Nov 4, 2025
the corresponding logic from scripts/build_utils.sh, added in ceph#2043, was not specific to release builds the rgw team needs this enabled for all packages tested in ci, because we rely heavily on valgrind coverage. the rgw suite has been an absolute mess of valgrind issues lately, and this appears to be the primary cause Signed-off-by: Casey Bodley <cbodley@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build boost with valgrind annotations enabled so they run cleanly under valgrind for https://tracker.ceph.com/issues/56500