build_utils.sh: Don't build containers for luminous either#1613
build_utils.sh: Don't build containers for luminous either#1613djgalloway wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: David Galloway <dgallowa@redhat.com>
| # not ship this package | ||
| if [[ "$CI_CONTAINER" && "$BRANCH" =~ nautilus ]]; then | ||
| # we don't build containers for nautilus or older | ||
| if [[ "$CI_CONTAINER" && "$BRANCH" =~ luminous|nautilus ]]; then |
There was a problem hiding this comment.
i consider #1607 a workaround to stop the build failure before we have a decent fix addressing ceph/ceph-container#1706 (comment), because the container image build failure is now considered a fatal error.
if nobody is consuming the luminous and nautilus images, why are we building it in build-push-ceph-container-imgs.sh, just for the sake of completeness?
There was a problem hiding this comment.
if nobody is consuming the luminous and nautilus images, why are we building it in
build-push-ceph-container-imgs.sh, just for the sake of completeness?
My guess is because when we started building containers, luminous and nautilus were the latest releases and CentOS8 wasn't out yet so this wasn't an issue.
There was a problem hiding this comment.
I don't know who's consuming what Ceph release builds. I do know the container build stuff seems to be getting more fragile as we add more special cases at various levels of the build. It seems like "whether we build" should be set by build-utils.sh and "how we build" should be set by ceph-container, though, with (obviously) as few special cases as possible.
|
luminous is EOL |
Signed-off-by: David Galloway dgallowa@redhat.com