ceph-dev-*-build: reset CI_CONTAINER when building nautilus#1607
Merged
tchaikov merged 1 commit intoceph:masterfrom Jul 3, 2020
Merged
ceph-dev-*-build: reset CI_CONTAINER when building nautilus#1607tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
Signed-off-by: Kefu Chai <kchai@redhat.com>
sebastian-philipp
approved these changes
Jul 2, 2020
Comment on lines
+1077
to
+1078
| # ceph-container includes ceph-mgr-cephadm by default, but nautilus does | ||
| # not ship this package |
Contributor
There was a problem hiding this comment.
which sounds strange. isn't it the job of ceph-container to decide which ceph version ships which packages? anyway. this PR lgtm.
Contributor
Author
There was a problem hiding this comment.
which sounds strange. isn't it the job of ceph-container to decide which ceph version ships which packages?
right. but nautilus does not have ceph-mgr-cephadm at all. ceph-container cannot ship the package which does not even exist in upstream.
2 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com