ceph-perf-pull-requests: use clang for crimson perf test#1576
Merged
tchaikov merged 2 commits intoceph:masterfrom Jun 1, 2020
Merged
ceph-perf-pull-requests: use clang for crimson perf test#1576tchaikov merged 2 commits intoceph:masterfrom
tchaikov merged 2 commits intoceph:masterfrom
Conversation
Contributor
Author
rzarzynski
approved these changes
Jun 1, 2020
| export FOR_MAKE_CHECK=true | ||
| cxx_compiler=g++ | ||
| c_compiler=gcc | ||
| for i in $(seq 11 -1 8); do |
Contributor
There was a problem hiding this comment.
We're doing auto-detection of available Clang's version with a fallback to GCC.
Contributor
Author
There was a problem hiding this comment.
yes, starts from 11 for future-proof.
ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml
Outdated
Show resolved
Hide resolved
| --cmake-args "-DCMAKE_CXX_COMPILER=$cxx_compiler -DCMAKE_C_COMPILER=$c_compiler -DCMAKE_BUILD_TYPE=Release -DWITH_SEASTAR=ON -DWITH_TESTS=OFF" \ | ||
| vstart-base crimson-osd | ||
| src/script/run-cbt.sh --build-dir $PWD/build --source-dir $PWD --cbt ${{WORKSPACE}}/cbt -a $archive_dir src/test/crimson/cbt/radosbench_4K_read.yaml | ||
| else |
Contributor
There was a problem hiding this comment.
ACK, classical stays unaffected.
for detecting test failures on clang Signed-off-by: Kefu Chai <kchai@redhat.com>
so we can detect build failures on clang Signed-off-by: Kefu Chai <kchai@redhat.com>
b2efe5e to
79804b7
Compare
Contributor
Author
|
@rzarzynski we need to have ceph/ceph#35336 first. |
This was referenced Jun 1, 2020
|
@mkogan1 FYI (and see the ref'ed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.