pybind/*/setup.py: fix clang detection with ccache#35336
Merged
tchaikov merged 1 commit intoceph:masterfrom Jun 1, 2020
Merged
pybind/*/setup.py: fix clang detection with ccache#35336tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
Signed-off-by: Samuel Just <sjust@redhat.com>
Contributor
Author
|
otherwise we have |
Contributor
Author
rzarzynski
approved these changes
Jun 1, 2020
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
Looks good! This bug could have affected GCC builds as well. I'm curious whether there is any significant difference because of parameter omission.
| extra_compile_args=filter_unsupported_flags( | ||
| compiler.compiler[0], | ||
| distutils.sysconfig.get_config_var('CFLAGS').split()), | ||
| compiler.compiler[1:] + distutils.sysconfig.get_config_var('CFLAGS').split()), |
Contributor
There was a problem hiding this comment.
| @@ -72,7 +72,7 @@ def get_python_flags(libs): | |||
| libraries=libs + py_libs, | |||
| extra_compile_args=filter_unsupported_flags( | |||
Contributor
There was a problem hiding this comment.
ACK: -fstack-clash-protection came from the new_compiler() call.
filter_unsupported_flags() just squeezes some compiler options if it detects clang.
def filter_unsupported_flags(compiler, flags):
args = takewhile(lambda argv: not argv.startswith('-'), [compiler] + flags)
if any('clang' in arg for arg in args):
return list(filterfalse(lambda f:
f in ('-mcet',
'-fstack-clash-protection',
'-fno-var-tracking-assignments',
'-Wno-deprecated-register',
'-Wno-gnu-designator') or
f.startswith('-fcf-protection'),
flags))
else:
return flags
Contributor
Author
Contributor
Author
|
@athanatos sorry for stealing your commits and merging it without your blessings. i really want to test and merge ceph/ceph-build#1576 sooner. |
Contributor
|
No worries, I hadn't gotten around to making sure that was the right
solution ;).
-Sam
…On Mon, Jun 1, 2020 at 7:47 AM Kefu Chai ***@***.***> wrote:
@athanatos <https://github.com/athanatos> sorry for stealing your commits
and merging it without your blessings. i really want to test and merge
ceph/ceph-build#1576 <ceph/ceph-build#1576>
sooner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35336 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEFADUM3JCOSZC2R2VY3MLRUO5OVANCNFSM4NPW2DUA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Just sjust@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox