hammer: rgw: user quota may not adjust on bucket removal#8113
Merged
oritwas merged 1 commit intoceph:hammerfrom Jun 7, 2016
Merged
hammer: rgw: user quota may not adjust on bucket removal#8113oritwas merged 1 commit intoceph:hammerfrom
oritwas merged 1 commit intoceph:hammerfrom
Conversation
CXX rgw/librgw_la-rgw_tools.lo
rgw/rgw_bucket.cc: In function 'int rgw_remove_bucket(RGWRados*, const string&, rgw_bucket&, bool)':
rgw/rgw_bucket.cc:436:50: error: 'struct rgw_bucket' has no member named 'tenant'
ret = rgw_bucket_sync_user_stats(store, bucket.tenant, bucket.name);
^
|
cedc30f to
5c5f206
Compare
5c5f206 to
aa8702d
Compare
Contributor
Author
|
@dachary thanks for reminder. Already corrected |
|
@Vicente-Cheng http://tracker.ceph.com/issues/15023#note-5 shows the conflict resolution was done in a minimal way and matches the conflict resolution comment. 👍 |
ghost
pushed a commit
that referenced
this pull request
Apr 5, 2016
…ucket removal Reviewed-by: Loic Dachary <ldachary@redhat.com>
aa8702d to
c5766dd
Compare
Description: If the user/admin removes a bucket using --force/--purge-objects options with s3cmd/radosgw-admin respectively, the user stats will continue to reflect the deleted objects for quota purposes, and there seems to be no way to reset them. User stats need to be sync'ed prior to bucket removal. Solution: Sync user stats before removing a bucket. Fixes: ceph#14507 Signed-off-by: Edward Yang <eyang@us.fujitsu.com> (cherry picked from commit 0650799) Conflicts: src/rgw/rgw_op.cc reordering the check seqence and replace some op_ret to ret Backport Change: We remove the `tenant` parameter because this feature is not introduced on hammer version. The rgw multi-tenant feature is introduced on pr#6784 (ceph#6784) This feature is supported from v10.0.2 and later version.
c5766dd to
c722d00
Compare
smithfarm
added a commit
that referenced
this pull request
Jun 1, 2016
…ucket removal Reviewed-by: Nathan Cutler <ncutler@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15023