ceph-disk/test: fix test_prepare.py::TestPrepare tests#7549
Merged
tchaikov merged 1 commit intoceph:masterfrom Feb 6, 2016
Merged
ceph-disk/test: fix test_prepare.py::TestPrepare tests#7549tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
actually we are verifying if the variable is an instance of specified class. for example, the `prepare.data` should be a `PrepareFilestoreData` if `--bluestore` is not specified. Signed-off-by: Kefu Chai <kchai@redhat.com>
09178d4 to
08364c2
Compare
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
Contributor
Author
|
the failure is it is spotted in my local env, but i thought it was due to the way i started the test. but seem it's not. will look into it later. |
tchaikov
added a commit
that referenced
this pull request
Feb 6, 2016
ceph-disk/test: fix test_prepare.py::TestPrepare tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
Contributor
Author
|
thanks for your quick review @dachary =) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com