time: Have skewing-now call non-skewing now#7466
Merged
liewegas merged 2 commits intoceph:masterfrom Feb 6, 2016
Merged
Conversation
wjwithagen
added a commit
to wjwithagen/ceph
that referenced
this pull request
Feb 5, 2016
So this route does not need to differentiate between COARSE, FAST, POSIX gettime calls. Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
For the real-time clocks, Ceph's testing infrastructure likes to be able to inject a skew. To avoid pulling CephContext into ceph_time.h these are moved to ceph_time.cc. The original way this was done called clock_gettime in both places. This is an unnecessary duplication and apparently error-prone. So only call clock_gettime from one place. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
This fixes a compile error under clang and fixes another FreeBSD porting issue. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
6713571 to
672a694
Compare
wjwithagen
added a commit
to wjwithagen/ceph
that referenced
this pull request
Feb 5, 2016
So this route does not need to differentiate between COARSE, FAST, POSIX gettime calls. Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
liewegas
added a commit
that referenced
this pull request
Feb 6, 2016
common: time: have skewing-now call non-skewing now
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the real-time clocks, Ceph's testing infrastructure likes to be able to
inject a skew. To avoid pulling CephContext into ceph_time.h these are moved to
ceph_time.cc. The original way this was done called clock_gettime in both
places.
This is an unnecessary duplication and apparently error-prone. So only call
clock_gettime from one place.
Signed-off-by: Adam C. Emerson aemerson@redhat.com