mgr/nvmeof: Adding missing CLICommand field to nvmeof mgr module#67782
Merged
mgr/nvmeof: Adding missing CLICommand field to nvmeof mgr module#67782
Conversation
adk3798
approved these changes
Mar 13, 2026
Contributor
adk3798
left a comment
There was a problem hiding this comment.
Tested this on an orch/cephadm job that had previously failed waiting for the cluster to become healthy due to the nvmeof module crashing with
the module that crashed was the nvmeof module
Mar 13 14:33:28 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: 2026-03-13T14:33:28.862+0000 7f161d164fc0 -1 mgr[py] Exception calling _register_commands on nvmeof
Mar 13 14:33:28 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: 2026-03-13T14:33:28.862+0000 7f161d164fc0 -1 mgr[py] Traceback (most recent call last):
Mar 13 14:33:28 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: File "/usr/share/ceph/mgr/mgr_module.py", line 1107, in _register_commands
Mar 13 14:33:28 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: cls.COMMANDS.extend(cls.CLICommand.dump_cmd_list())
Mar 13 14:33:28 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: AttributeError: type object 'NVMeoF' has no attribute 'CLICommand'
Mar 13 14:33:28 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]:
Mar 13 14:33:29 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: /lib64/python3.9/site-packages/scipy/__init__.py:73: UserWarning: NumPy was imported from a Python sub-interpre>
Mar 13 14:33:29 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: Improvements in the case of bugs are welcome, but is not on the NumPy roadmap, and full support may require sig>
Mar 13 14:33:29 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: from numpy import show_config as show_numpy_config
Mar 13 14:33:32 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: Client ('10.20.193.121', 60378) lost — peer dropped the TLS connection suddenly, during handshake: (6, 'TLS/SSL>
Mar 13 14:33:37 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: Client ('10.20.193.121', 50558) lost — peer dropped the TLS connection suddenly, during handshake: (6, 'TLS/SSL>
Mar 13 14:33:54 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: ignoring --setuser ceph since I am not root
Mar 13 14:33:54 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: ignoring --setgroup ceph since I am not root
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: 2026-03-13T14:33:55.053+0000 7fef6b411fc0 -1 mgr[py] Exception calling _register_commands on nvmeof
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: 2026-03-13T14:33:55.053+0000 7fef6b411fc0 -1 mgr[py] Traceback (most recent call last):
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: File "/usr/share/ceph/mgr/mgr_module.py", line 1107, in _register_commands
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: cls.COMMANDS.extend(cls.CLICommand.dump_cmd_list())
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: AttributeError: type object 'NVMeoF' has no attribute 'CLICommand'
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]:
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: /lib64/python3.9/site-packages/scipy/__init__.py:73: UserWarning: NumPy was imported from a Python sub-interpre>
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: Improvements in the case of bugs are welcome, but is not on the NumPy roadmap, and full support may require sig>
Mar 13 14:33:55 trial121 ceph-80c7f0da-1ee9-11f1-a2b8-d404e6e7d460-mgr-trial121-fejwjs[37284]: from numpy import show_config as show_numpy_config
and this patch got that test to work
Member
|
@Hezko @VallariAg why wasn't this caught in the QA? |
batrick
approved these changes
Mar 13, 2026
phlogistonjohn
approved these changes
Mar 13, 2026
Contributor
|
make check failure is not a flake: |
Fixes: https://tracker.ceph.com/issues/75492 Signed-off-by: Redouane Kachach <rkachach@ibm.com>
9840ba1 to
80d50ba
Compare
Contributor
Author
Thanks for testing the fix @adk3798. I'll merge it as soon as the CI passes correctly. |
Contributor
@batrick Oh this is starnge, @rkachach 's fix includes a part from a commit which is included in my original PR, and was included in the version we tested in QA. but when I now look at the cherry picked commit that was merged it is missing. I guess I somehow omitted it by mistake when rebasing. sorry for that. sorry for that guys, and thanks for the quick resolve @rkachach ! 🙏 |
Contributor
Author
|
jenkins test windows |
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/23085490038 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/75492
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.