Skip to content

mgr/nvmeof: add missing CLICommand to the module#67607

Closed
avanthakkar wants to merge 1 commit intoceph:mainfrom
avanthakkar:fix-nvmeof-attr-error
Closed

mgr/nvmeof: add missing CLICommand to the module#67607
avanthakkar wants to merge 1 commit intoceph:mainfrom
avanthakkar:fix-nvmeof-attr-error

Conversation

@avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Mar 2, 2026 •
edited
Loading

PR #67167 caused mgr crash with Traceback:

Mar 02 12:19:14 ceph-vm-0 ceph-b32516c2-1631-11f1-8bb0-52540004db9b-mgr-ceph-vm-0-vzmahz[2362]: 2026-03-02T12:19:14.468+0000 7fe8b8dc0fc0 -1 mgr[py] Exception calling _register_commands on nvmeof
Mar 02 12:19:14 ceph-vm-0 ceph-b32516c2-1631-11f1-8bb0-52540004db9b-mgr-ceph-vm-0-vzmahz[2362]: 2026-03-02T12:19:14.468+0000 7fe8b8dc0fc0 -1 mgr[py] Traceback (most recent call last):
Mar 02 12:19:14 ceph-vm-0 ceph-b32516c2-1631-11f1-8bb0-52540004db9b-mgr-ceph-vm-0-vzmahz[2362]:   File "/usr/share/ceph/mgr/mgr_module.py", line 1107, in _register_commands
Mar 02 12:19:14 ceph-vm-0 ceph-b32516c2-1631-11f1-8bb0-52540004db9b-mgr-ceph-vm-0-vzmahz[2362]:     cls.COMMANDS.extend(cls.CLICommand.dump_cmd_list())
Mar 02 12:19:14 ceph-vm-0 ceph-b32516c2-1631-11f1-8bb0-52540004db9b-mgr-ceph-vm-0-vzmahz[2362]: AttributeError: type object 'NVMeoF' has no attribute 'CLICommand'
Mar 02 12:19:14 ceph-vm-0 ceph-b32516c2-1631-11f1-8bb0-52540004db9b-mgr-ceph-vm-0-vzmahz[2362]: 
Mar 02 12:19:14 ceph-vm-0 ceph-mgr[2366]: mgr[py] Traceback (most recent call last):
                                            File "/usr/share/ceph/mgr/mgr_module.py", line 1107, in _register_commands
                                              cls.COMMANDS.extend(cls.CLICommand.dump_cmd_list())
                                          AttributeError: type object 'NVMeoF' has no attribute 'CLICommand'

This PR intends to fix this error by adding missing CLICommand attr to the nvmeof module

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@avanthakkar
mgr/nvmeof: add missing CLICommand to the module
75e99dc 
Fixed AttributeError: type object 'NVMeoF' has no attribute 'CLICommand'

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
@github-actions github-actions bot added the pybind label Mar 2, 2026
@avanthakkar avanthakkar mentioned this pull request Mar 2, 2026
Merged
14 tasks
@batrick
Copy link
Member

batrick commented Mar 2, 2026

No. The answer is not to fix the bugs incrementally. @Hezko needs to start over and have this QA'd properly.

#67608

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@avanthakkar
Copy link
Contributor Author

avanthakkar commented Mar 2, 2026

Closing in favor of #67608

@avanthakkar avanthakkar closed this Mar 2, 2026
@Hezko Hezko mentioned this pull request Mar 13, 2026
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick Awaiting requested review from batrick

@bill-scales bill-scales Awaiting requested review from bill-scales

@Hezko Hezko Awaiting requested review from Hezko

Assignees

No one assigned

Labels

needs-rebase pybind wip-athakkar2-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avanthakkar @batrick