qa: allow multiple mgr sessions during eviction test#67556
Merged
qa: allow multiple mgr sessions during eviction test#67556
Conversation
Fixes: https://tracker.ceph.com/issues/70580 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
vshankar
reviewed
Mar 2, 2026
Contributor
vshankar
left a comment
There was a problem hiding this comment.
minor nits, otherwise lgtm.
| # Helper to get mgr-specific sessions (type 16) | ||
| def get_mgr_sessions(): | ||
| all_sessions = self._session_list() | ||
| mgr_sessions = [s for s in all_sessions if s.get('auth_name', {}).get('type') == 16] |
Contributor
There was a problem hiding this comment.
Nice use of recently added enhancement 👍
|
|
||
| # Ensure we start with only mgr sessions (if any) | ||
| all_s, mgr_s = get_mgr_sessions() | ||
| self.assertEqual(len(all_s), len(mgr_s), f"Non-mgr sessions found: {all_s}") |
Contributor
There was a problem hiding this comment.
nit: did you mean
f"Non-mgr sessions found: {all_s - len(mgr_s)}"
?
vshankar
approved these changes
Mar 3, 2026
Contributor
vshankar
left a comment
There was a problem hiding this comment.
Conditional approval (comments needs to be taken to closure).
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/75334. |
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Mar 16, 2026
* refs/pull/67556/head: Reviewed-by: Venky Shankar <vshankar@redhat.com>
vshankar
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/70580
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.