cephdm: add support for raw bluestore + crimson OSD deployment#67374
cephdm: add support for raw bluestore + crimson OSD deployment#67374shraddhaag merged 1 commit intoceph:mainfrom
Conversation
This commit adds support for deploying crimson OSDs using cephadm with the method raw. Support for lvm crimson OSD was added previously in: ceph#66811. Fixes: https://tracker.ceph.com/issues/74960 Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
2874f07 to
0fe1311
Compare
Matan-B
left a comment
There was a problem hiding this comment.
Doesn't ceph volume needs to support raw first?
Same as #64323 added lvm support in ceph vol.
I think we can also decide to not support raw for now.
afaiu lvm should be sufficient for initial deployments.
@shraddhaag, @guits wdyt?
ceph-volume already supports raw for bluestore objectstore. With this PR, all we are doing is allowing crimson OSDs to be deployed with method raw when the objectstore is bluestore. Ceph-volume does not support raw with seastore and we do not enable it here as well.
Specifically regarding the bug that user was facing, they were using the method raw with bluestore when deploying crimson OSDs. I tested with the changes in this PR and this works fine! So we can support raw for crimson but only with bluestore backend. |
|
jenkins test make check arm64 |
Matan-B
left a comment
There was a problem hiding this comment.
Doesn't ceph volume needs to support raw first?
ceph-volume already supports raw for bluestore objectstore.
With this PR, all we are doing is allowing crimson OSDs to be deployed with method raw when the objectstore is bluestore. Ceph-volume does not support raw with seastore and we do not enable it here as well.
I think we can also decide to not support raw for now.
Specifically regarding the bug that user was facing, they were using the method raw with bluestore when deploying crimson OSDs. I tested with the changes in this PR and this works fine! So we can support raw for crimson but only with bluestore backend.
Ah, I missed the fact that the issue was for bluestore raw/crimson osd. Nice catch!
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/22213531294 |
This commit adds support for deploying crimson OSDs using cephadm with the method raw for bluestore objectstore.
Support for lvm crimson OSD was added previously in: #66811.
Fixes: https://tracker.ceph.com/issues/74960
Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.