ceph-volume: add seastore OSDs support#64323
Conversation
|
jenkins ceph-volume unit tests |
Matan-B
left a comment
There was a problem hiding this comment.
That's great, thank you!
| if self.identity.daemon_type == 'osd' and config_json is not None: | ||
| if 'objectstore' in config_json: | ||
| objectstore = config_json['objectstore'] | ||
| ctr.args = ctr.args + [f'--osd-objectstore={objectstore}'] |
There was a problem hiding this comment.
Note: this depends on #63817 as currently crimson expects --crimson-osd-objectstore.
f2789f5 to
45bcdb3
Compare
This adds the seastore OSD objectstore support to ceph-volume. Fixes: https://tracker.ceph.com/issues/71414 Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
|
jenkins ceph-volume unit tests |
cyx1231st
left a comment
There was a problem hiding this comment.
Mostly bluestore refactors I'm not familiar of.
LGTM as an initial step, as long as it works for seastore.
Please let me know if there is any question in interacting with seastore.
|
|
||
| def has_seastore_label(device_path: str) -> bool: | ||
| is_seastore = False | ||
| seastore_disk_signature = b'seastore block device\n' # 23 bytes including newline |
There was a problem hiding this comment.
the has_seastore_label() function is not used anywhere in ceph-volume yet, it has been implemented in anticipation of potential future use.
There was a problem hiding this comment.
Can we add the the usage of seastore in this PR as well? Are there any missing deps?
Ah, this is needed for raw devices only
This adds the seastore OSD objectstore support to ceph-volume.
Fixes: https://tracker.ceph.com/issues/71414