crimson: Use osd_objectstore instead of using crimson_osd_objectstore#63817
crimson: Use osd_objectstore instead of using crimson_osd_objectstore#63817
Conversation
|
jenkins test make check |
|
jenkins test make check |
There was a problem hiding this comment.
what do you think about:
crimson: Use osd_objectstore instead of using crimson_osd_objectstore
Originally the idea with introducing a crimson dedicated configurable was to allow
changing the default object store to SeaStore without affecting the Classic option.
Moreover, if we were to consider hybrid clusters, different OSD types would require
two different dedicated options.
Given that cephadm (and possibly other orchestrators) use `--osd-obejctstore` to
set the backend - we would prefer to retain (at least for now) this behavior to not
break the **existing** cluster deployment methods.
Note: A follow up PR would be pushed against cephadm to fully support Seastore as
backend option
src/vstart.sh
Outdated
| EOF | ||
| else | ||
| wconf <<EOF | ||
| wconf <<EOF |
There was a problem hiding this comment.
This line is shouldn't be here, we should revert same as before: 15e746b
kstore fsck on mount = true
osd objectstore = $objectstore
EOF
1d25862 to
a9c580d
Compare
I am ok with this. |
|
jenkins test make check |
Matan-B
left a comment
There was a problem hiding this comment.
lgtm!
Can you please run this thorough the suite to make sure everything is correct?
a9c580d to
9b539a5
Compare
Config Diff Tool Output- removed: crimson_osd_objectstore (crimson.yaml.in)
The above configuration changes are found in the PR. Please update the relevant release documentation if necessary. |
Originally the idea with introducing a crimson dedicated
configurable was to allow changing the default object store to
SeaStore without affecting the Classic option. Moreover, if we
were to consider hybrid clusters, different OSD types would require
two different dedicated options.
Given that cephadm (and possibly other orchestrators) use
`--osd-obejctstore` to set the backend - we would prefer to
retain (at least for now) this behavior to not break the
**existing** cluster deployment methods.
Note: A follow up PR would be pushed against cephadm to
fully support Seastore as backend option.
Fixes: https://tracker.ceph.com/issues/71593
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
9b539a5 to
bd262c3
Compare
|
jenkins test make check |
The osd_objectstore supports all type of objectstores (bluestore/filestore/memstore/seastore/cyanstore) so there is no benefit to keep separate option for crimson.
Fixes: https://tracker.ceph.com/issues/71593
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition