mds: improve debugging for snaprealms marked subvolume#67124
Merged
mds: improve debugging for snaprealms marked subvolume#67124
Conversation
So that it doesn't match in greps for the snaprealm.
Now looks like:
2026-01-29T12:05:52.607-0500 7defd1a64640 10 mds.0.cache journal_cow_dentry follows 1 < first on [inode 0x10000000002 [...2,head] /volumes/_nogroup/foo/ auth v16 pv20 ap=1 sr=0x5c1a558a66c0 DIRTYPARENT f(v0 m2026-01-29T12:05:52.593286-0500 2=1+1) n(v0 rc2026-01-29T12:05:52.596656-0500 b122 3=1+2) (isnap sync r=1) (inest lock w=1) (ifile excl w=1) (iversion lock w=1 last_client=4344) (iquiesce lock w=1 last_client=4344) caps={4344=pAsLsXsFsx/-@6},l=4344 | request=0 lock=5 dirfrag=1 caps=1 dirtyparent=1 dirty=1 waiter=0 authpin=1 0x5c1a5a8cb080]
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/74652
So we can verify the state of the SnapRealm if we hit EXDEV.
Now looks like:
2026-01-29T12:05:52.603-0500 7defd1a64640 20 mds.0.server src_realm snaprealm(0x10000000002 seq 1 lc 0 cr 1 cps 2 snaps={} subvol last_modified 0.000000 change_attr 0 is_snapdir_visible 1 0x5c1a558a66c0)
2026-01-29T12:05:52.603-0500 7defd1a64640 20 mds.0.server dest_realm snaprealm(0x10000000002 seq 1 lc 0 cr 1 cps 2 snaps={} subvol last_modified 0.000000 change_attr 0 is_snapdir_visible 1 0x5c1a558a66c0)
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/74652
And clean up this code some.
Now looks like:
2026-01-29T12:05:52.607-0500 7defd1a64640 10 mds.0.server set_trace_dist snaprealm snaprealm(0x10000000002 seq 1 lc 0 cr 1 cps 2 snaps={} subvol last_modified 0.000000 change_attr 0 is_snapdir_visible 1 0x5c1a558a66c0) len=148
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Fixes: https://tracker.ceph.com/issues/74652
Member
Author
|
jenkins test make check arm64 |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/74811. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Feb 12, 2026
* refs/pull/67124/head: mds: indicate whether SnapRealm is a subvolume in dump mds: dump SnapRealm for src/dest in link operations mds: abbreviate snaprealm in CInode dump
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/75334. |
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Mar 16, 2026
* refs/pull/67124/head:
vshankar
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.