Skip to content

tentacle: pybind/mgr/dashboard: dashboard/requirements-lint.txt: re-pin rsscheck#66877

Merged
batrick merged 2 commits intoceph:tentaclefrom
ronen-fr:wip-rf-66774-tentacle
Feb 12, 2026
Merged

tentacle: pybind/mgr/dashboard: dashboard/requirements-lint.txt: re-pin rsscheck#66877
batrick merged 2 commits intoceph:tentaclefrom
ronen-fr:wip-rf-66774-tentacle

Conversation

@ronen-fr
Copy link
Contributor

Required for install-deps.sh to complete on Fedora 43, as the previously specified rstcheck Wheel version
(3.3.1) is not available:
Fedora 43 defaults to Python 3.14, but rstcheck 3.3.1 does not support Python 3.14 (see supported versions)
rstcheck 6.2.0 was the first version to add Python 3.14 support (release info)

A second commit fixes calls to rstcheck, to match API changes in newer rstcheck versions.

A backport of #66774.
Fixes https://tracker.ceph.com/issues/74372.
Original tracker: https://tracker.ceph.com/issues/74371

As the requested Wheel for 'rstcheck==3.3.1' is not available
for Fedora 43:

Fedora 43 ships with Python 3.14 as the default interpreter.
rstcheck 3.3.1 doesn't support Python 3.14 (see supported
versions at https://pypi.org/project/rstcheck/3.3.1/)
rstcheck 6.2.0 was the first version to add Python 3.14 support
(release info: https://pypi.org/project/rstcheck/6.2.0/)

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit 4f9be67)
As we have upgraded to rstcheck >= 6.0.0, we must now use
the new command-line options.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit b7fd12e)
@ronen-fr ronen-fr requested a review from a team as a code owner January 10, 2026 05:41
@github-actions github-actions bot added this to the tentacle milestone Jan 10, 2026
@ronen-fr ronen-fr added bug-fix backport tentacle PRs that is a tentacle back-port labels Jan 10, 2026
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Jan 12, 2026
@ronen-fr
Copy link
Contributor Author

jenkins test api

@ronen-fr
Copy link
Contributor Author

jenkins test make check

Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronen-fr
Copy link
Contributor Author

ronen-fr commented Feb 4, 2026

jenkins test make check

@ronen-fr
Copy link
Contributor Author

ronen-fr commented Feb 7, 2026

jenkins test api

@shraddhaag
Copy link
Contributor

@github-project-automation github-project-automation bot moved this from Reviewer approved to Review in progress in Ceph-Dashboard Feb 10, 2026
@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Ceph-Dashboard Feb 12, 2026
@batrick batrick merged commit 67512d8 into ceph:tentacle Feb 12, 2026
12 of 14 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants