pybind/mgr/dashboard: dashboard/requirements-lint.txt: re-pin rsscheck#66774
pybind/mgr/dashboard: dashboard/requirements-lint.txt: re-pin rsscheck#66774
Conversation
|
@tchaikov - that's a line you had once added. Am I missing anything? |
0f72e18 to
946718d
Compare
946718d to
92f429a
Compare
|
jenkins test make check arm64 |
tchaikov
left a comment
There was a problem hiding this comment.
the commit message reads:
As the requested Wheel for 'rstcheck==3.3.1' is not available for Fedora 43 (which defaults to Python 3.14).
without more context, reviewer and our posterity would not be able to understand how Python 3.14 is connected to rstcheck 3.3.1
b9e28e0 to
479ada9
Compare
|
the "make check (arm64)" CI workflow failed: this failure is not relevant to the change, and should be fixed by #66733 |
|
jenkins test make check arm64 |
As the requested Wheel for 'rstcheck==3.3.1' is not available for Fedora 43: Fedora 43 ships with Python 3.14 as the default interpreter. rstcheck 3.3.1 doesn't support Python 3.14 (see supported versions at https://pypi.org/project/rstcheck/3.3.1/) rstcheck 6.2.0 was the first version to add Python 3.14 support (release info: https://pypi.org/project/rstcheck/6.2.0/) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
As we have upgraded to rstcheck >= 6.0.0, we must now use the new command-line options. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
479ada9 to
b7fd12e
Compare
epuertat
left a comment
There was a problem hiding this comment.
LGTM! Thanks, @ronen-fr !
BTW, we should start adding SHA-256 hashes to our Python deps for SCM safety. That means adding the --require-hashes flag (or PIP_REQUIRE_HASHES env var) in the pip install step.
The first time, pip will complain and provide the expected hash:
> python -mvenv /tmp/venv
> /tmp/venv/bin/pip install --require-hashes -r src/pybind/mgr/dashboard/requirements-lint.txt
Collecting pylint==2.6.0 (from -r src/pybind/mgr/dashboard/requirements-lint.txt (line 1))
Downloading pylint-2.6.0-py3-none-any.whl (325 kB)
[notice] A new release of pip is available: 24.3.1 -> 25.3
[notice] To update, run: python -m pip install --upgrade pip
ERROR: Hashes are required in --require-hashes mode, but they are missing from some requirements. Here is a list of those requirements along with the hashes their downloaded archives actually had. Add lines like these to your requirements files to prevent tampering. (If you did not enable --require-hashes manually, note that it turns on automatically when any package has a hash.)
pylint==2.6.0 --hash=sha256:bfe68f020f8a0fece830a22dd4d5dddb4ecc6137db04face4c3420a46a52239fAn alternative (better) approach would be to use a requirements-*.in file and generate the final hashed requirements file with pip-compile (from pip-tools).
|
jenkins test windows |
|
jenkins test dashboard tests |
|
jenkins test dashboard cephadm |
|
jenkins test dashboard |
|
@epuertat - "shaman" builds are OK. Is there a point in Teuthology tests, or should I merge this now? |
|
It looks like this PR was merged before the Ceph dashboard tests finished. For dashboard-related PRs, we usually wait for those tests to pass. Unfortunately, due to a CI limitation, we can’t mark them as required only for dashboard PRs. cc @ronen-fr @tchaikov for visibility Thanks! |
Required for install-deps.sh to complete on Fedora 43, as the previously specified rstcheck Wheel version
(3.3.1) is not available:
Fedora 43 defaults to Python 3.14, but rstcheck 3.3.1 does not support Python 3.14 (see supported versions)
rstcheck 6.2.0 was the first version to add Python 3.14 support (release info)
A second commit fixes calls to rstcheck, to match API changes in newer rstcheck versions