Closed
Conversation
Signed-off-by: Samuel Just <sjust@redhat.com>
…to allow unpickle to work correctly Signed-off-by: Samuel Just <sjust@redhat.com>
This commit adds a mgr_subinterpreter_modules config to cause specified modules (or all if * is specified) to be loaded in individual subinterpreters. This changes the default behavior of ceph-mgr from running each module in a distinct subinterpreter to running them all in the same main interpreter. We can reintroduce subinterpreter support over time by adding modules to the list as we test them. Fixes: https://tracker.ceph.com/issues/73857 Fixes: https://tracker.ceph.com/issues/73859 Signed-off-by: Samuel Just <sjust@redhat.com>
…ependent CLICommands type Otherwise, the class members on MgrModule are global to all modules in the same interpreter. Following commits will fix users. Signed-off-by: Samuel Just <sjust@redhat.com>
Classes derived from MgrModule now have their own CLI*Command instances bound during class body execution. Signed-off-by: Samuel Just <sjust@redhat.com>
orchestrator and cephadm relied on CLICommandMeta to bypass the global behavior of CLICommand. That is no longer a problem, so replace CLICommandMeta with OrchestratorCLICommandBase to preserve the magic error wrapping. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
…dRegistryMeta Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Config Diff Tool Output+ added: mgr_subinterpreter_modules (mgr.yaml.in)
The above configuration changes are found in the PR. Please update the relevant release documentation if necessary. |
Contributor
Author
|
Going to just go with some per-module boilerplate to avoid the metaclass magic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.