neorados: specify alignments for aligned_storage#66396
neorados: specify alignments for aligned_storage#66396
Conversation
adamemerson
left a comment
There was a problem hiding this comment.
Thank you ever so much. This was the worst.
|
oops, |
the default alignment of `Alignment = std::bit_ceil(S)` was a very conservative estimate. reduce that to `alignof(std::max_align_t)` to match the old behavior, then assert on construction that the given alignment is large enough for the implementation's type Fixes: https://tracker.ceph.com/issues/73750 Signed-off-by: Casey Bodley <cbodley@redhat.com>
mkogan1
left a comment
There was a problem hiding this comment.
also fixes the following segf which occurs when performing radosgw-admin user create in a vstart env built with clang 19 and -march=native , ex:
echo ${RANDOM} ; gdb --args radosgw-admin user create --display-name="cosbench_s3" --uid=cosbench${RANDOM} --access-key b2345678901234567890${RANDOM} --secret b2345678901234567890123456
78901234567890${RANDOM} --debug_rgw=30
|
@cbodley I will test this to ensure it's working on the rados side. |
|
https://jenkins.ceph.com/job/ceph-pull-requests-arm64/83735/
|
|
jenkins test make check arm64 |
|
passed rgw qa https://pulpito.ceph.com/cbodley-2025-11-26_17:46:01-rgw-wip-73750-distro-default-smithi/ (failures expected) |
|
Running some rados tests here: |
|
This PR is under test in https://tracker.ceph.com/issues/74811. |
* refs/pull/66396/head: neorados: specify alignments for aligned_storage
|
This PR is under test in https://tracker.ceph.com/issues/75377. |
the default alignment of
Alignment = std::bit_ceil(S)was a very conservative estimate. reduce that toalignof(std::max_align_t)to match the old behavior, then assert on construction that the given alignment is large enough for the implementation's typeFixes: https://tracker.ceph.com/issues/73750
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.