Skip to content

qa/suites/thrash-old-clients/1-install: exclude ceph-osd-classic#66268

Merged
Matan-B merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-old-clients-installs
Nov 19, 2025
Merged

qa/suites/thrash-old-clients/1-install: exclude ceph-osd-classic#66268
Matan-B merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-old-clients-installs

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Nov 16, 2025 •
edited
Loading

a37b5b5 added ceph-osd-classic package. In old-clients tests we should try to install the new package as it is not available in older releases.

See for example the following thrash-old-clients:
https://pulpito.ceph.com/matan-2025-11-16_12:18:21-rados-wip-matanb-crimson-on-v2-distro-default-smithi/8605198

[ceph-source]
name=ceph source packages
baseurl=https://3.chacra.ceph.com/r/ceph/tentacle/0f53ef03682439e4d665ac69e35025b05ebfc590/centos/9/flavors/default/SRPMS
enabled=1
gpgcheck=0
type=rpm-md

With the changes in this PR:
https://pulpito.ceph.com/matan-2025-11-16_12:58:48-rados-wip-matanb-crimson-on-v2-distro-default-smithi/

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@Matan-B Matan-B requested a review from tchaikov November 16, 2025 12:57
@Matan-B Matan-B requested a review from a team as a code owner November 16, 2025 12:57
@Matan-B
Copy link
Contributor Author

Matan-B commented Nov 16, 2025 •
edited
Loading

Taken from #66229, as this should fix thrash-old-clients tests

https://pulpito.ceph.com/matan-2025-11-16_12:58:48-rados-wip-matanb-crimson-on-v2-distro-default-smithi/

This was referenced Nov 16, 2025
Merged
Merged
@Matan-B Matan-B requested a review from ljflores November 17, 2025 17:01
@Matan-B Matan-B force-pushed the wip-matanb-old-clients-installs branch from 28c1f68 to 412a0fc Compare November 17, 2025 17:15
ljflores
ljflores approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@ljflores ljflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. On the latest nightlies, the upgrade tests are also showing this error:
https://pulpito.ceph.com/teuthology-2025-11-16_20:00:21-rados-main-distro-default-smithi/8605314/

See https://pulpito.ceph.com/teuthology-2025-11-16_20:00:21-rados-main-distro-default-smithi/8605314/ for further examples.

So, we should also exclude the package for all releases in the upgrade suite that don't include it.

@Matan-B Matan-B force-pushed the wip-matanb-old-clients-installs branch from 412a0fc to 12f520d Compare November 17, 2025 17:37
@Matan-B
qa/suites: exclude ceph-osd-classic
84d4206 
a37b5b5 added ceph-osd-classic
package.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

Fixes: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-old-clients-installs branch from 12f520d to 84d4206 Compare November 17, 2025 17:45
Matan-B added a commit to Matan-B/ceph that referenced this pull request Nov 18, 2025
@Matan-B
qa/suites: exclude ceph-osd-crimson
63b567a 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B added a commit to Matan-B/ceph that referenced this pull request Nov 18, 2025
@Matan-B
qa/suites: exclude ceph-osd-crimson
d875ca0 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
Copy link
Contributor Author

Matan-B commented Nov 19, 2025

The change here only impacts /qa and doesn't need a dedicated build.
Tested:
https://pulpito.ceph.com/matan-2025-11-19_10:53:52-rados-main-distro-default-smithi/

All upgrade and old-clients runs passed the package dependency installs successfully.
Merging based on the above.

@Matan-B Matan-B merged commit d566702 into ceph:main Nov 19, 2025
13 checks passed
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

This is an automated message by src/script/redmine-upkeep.py.

I have resolved the following tracker ticket due to the merge of this PR:

No backports are pending for the ticket. If this is incorrect, please update the tracker
ticket and reset to Pending Backport state.

Update Log: https://github.com/ceph/ceph/actions/runs/19502384719

Matan-B added a commit to Matan-B/ceph that referenced this pull request Nov 19, 2025
@Matan-B
qa/suites: exclude ceph-osd-crimson
304e806 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B added a commit to Matan-B/ceph that referenced this pull request Nov 19, 2025
@Matan-B
qa/suites: exclude ceph-osd-crimson
807b32e 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@tchaikov
Copy link
Contributor

tchaikov commented Nov 20, 2025

Thanks @Matan-B for the quick fix.

samarahu pushed a commit to samarahu/ceph that referenced this pull request Nov 24, 2025
@Matan-B @samarahu
qa/suites: exclude ceph-osd-crimson
56099b9 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
ideepika pushed a commit to ideepika/ceph that referenced this pull request Nov 25, 2025
@Matan-B @ideepika
qa/suites: exclude ceph-osd-crimson
624159f 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B mentioned this pull request Dec 3, 2025
Merged
14 tasks
MattyWilliams22 pushed a commit to MattyWilliams22/ceph that referenced this pull request Dec 4, 2025
@Matan-B @MattyWilliams22
qa/suites: exclude ceph-osd-crimson
3e88b39 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
JoshuaGabriel pushed a commit to JoshuaGabriel/ceph that referenced this pull request Jan 7, 2026
@Matan-B @JoshuaGabriel
qa/suites: exclude ceph-osd-crimson
c9a940b 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
amathuria pushed a commit to amathuria/ceph that referenced this pull request Jan 19, 2026
@Matan-B @amathuria
qa/suites: exclude ceph-osd-crimson
8088fc6 
Similarly to ceph#66268.
Once crimson is enabled in RPM, ceph-osd-crimson will
be requried as a dependency.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

See: https://tracker.ceph.com/issues/73848

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzarzynski rzarzynski rzarzynski approved these changes

@ljflores ljflores ljflores approved these changes

@tchaikov tchaikov Awaiting requested review from tchaikov

Assignees

No one assigned

Labels

core needs-qa tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Matan-B @tchaikov @rzarzynski @ljflores @SrinivasaBharath