qa/tasks/cephadm: add support for distro-suffix#66171
Conversation
Signed-off-by: Samuel Just <sjust@redhat.com>
| if distro_suffix is not None: | ||
| ctx.ceph[cluster_name].image += '-' + distro_suffix | ||
| if flavor == "crimson-debug" or flavor == "crimson-release": | ||
| ctx.ceph[cluster_name].image += '-' + flavor |
There was a problem hiding this comment.
Generally looks OK to me. I am just curious if anyone else has any opinions on being able to (easily) split the tag into parts, in that case joining with a - conflicts a little with crimson-release. Should we consider joining the tag with dots . or + instead?
adk3798
left a comment
There was a problem hiding this comment.
LGTM, although I do agree with John's point that we might want to consider a different character as a splitter
|
@phlogistonjohn Honestly, I don't have an opinion. I'd like to merge this one now as we need it to test cephadm, but I'm perfectly happy to change it now or in a future PR if you pick a different delimiter. Just let me know. |
|
Have just been in this up to my ears with repairing the quay-pruner job (ceph/ceph-build#2496) and I don't have strong opinions other than to say we'll need to touch a lot of places if we change conventions on tags. Maybe we should, but there are lots of places to touch. So far I've been using either my human brain (such as it is) or tricksy REs to do the job and it hasn't been horrible. |
|
I pinged in the build sig channel, to see if anyone cares, but if you don't hear back in 12hrs just assume it's fine. |
It's fine then? |
|
This PR is under test in https://tracker.ceph.com/issues/73883. |
|
This PR is under test in https://tracker.ceph.com/issues/73884. |
|
Yup, it's fine. |
|
This PR is under test in https://tracker.ceph.com/issues/73885. |
|
This PR is under test in https://tracker.ceph.com/issues/73888. |
|
This PR is under test in https://tracker.ceph.com/issues/73889. |
* refs/pull/66171/head: qa/tasks/cephadm: add support for distro-suffix
|
This PR is under test in https://tracker.ceph.com/issues/74161. |
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.