Skip to content

qa/tasks: update egrep to 'grep -E'#66155

Merged
batrick merged 1 commit intoceph:mainfrom
athanatos:sjust/wip-egrep-fix
Jan 28, 2026
Merged

qa/tasks: update egrep to 'grep -E'#66155
batrick merged 1 commit intoceph:mainfrom
athanatos:sjust/wip-egrep-fix

Conversation

@athanatos
Copy link
Contributor

egrep marked as obsolete, update it to grep -E

Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing sign off?

Otherwise LGTM

@batrick
Copy link
Member

batrick commented Nov 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73883.

@batrick
Copy link
Member

batrick commented Nov 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73884.

@batrick
Copy link
Member

batrick commented Nov 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73885.

@batrick
Copy link
Member

batrick commented Nov 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73888.

@batrick
Copy link
Member

batrick commented Nov 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73889.

batrick added a commit to batrick/ceph that referenced this pull request Nov 18, 2025
* refs/pull/66155/head:
	qa/tasks: update egrep to 'grep -E'
@batrick
Copy link
Member

batrick commented Nov 20, 2025

@athanatos missing sign off

@batrick
Copy link
Member

batrick commented Dec 1, 2025

Also needs: ceph/teuthology#2113

@batrick
Copy link
Member

batrick commented Dec 1, 2025

@athanatos time to undraft?

@batrick
Copy link
Member

batrick commented Dec 9, 2025

This PR is under test in https://tracker.ceph.com/issues/74161.

egrep marked as obsolete, update it to grep -E

Signed-off-by: Nitzan Mordechai <nmordech@ibm.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
@athanatos athanatos force-pushed the sjust/wip-egrep-fix branch from 1f9fb25 to 6dfb84e Compare January 27, 2026 16:02
@athanatos athanatos marked this pull request as ready for review January 27, 2026 16:03
@athanatos athanatos requested a review from a team as a code owner January 27, 2026 16:03
@athanatos
Copy link
Contributor Author

@NitzanMordhai I think I pulled this from one of your branches, I added your signoff, can you approve it if that's ok?

@athanatos athanatos requested a review from batrick January 27, 2026 16:04
Copy link
Contributor

@NitzanMordhai NitzanMordhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@batrick batrick merged commit 73ede76 into ceph:main Jan 28, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants