tentacle: rgw: fix 'bucket rm --bypass-gc' for copied objects#66004
Merged
cbodley merged 1 commit intoceph:tentaclefrom Dec 9, 2025
Merged
tentacle: rgw: fix 'bucket rm --bypass-gc' for copied objects#66004cbodley merged 1 commit intoceph:tentaclefrom
cbodley merged 1 commit intoceph:tentaclefrom
Conversation
Contributor
|
pr testing completed and approved by @ivancich , details : https://tracker.ceph.com/issues/73809 |
Contributor
|
jenkins render docs |
BBoozmen
approved these changes
Nov 21, 2025
Contributor
|
jenkins render docs |
Contributor
|
jenkins test docs |
the `--bypass-gc` argument to `radosgw-admin bucket rm` causes us to call `RadosBucket::remove_bypass_gc()`, which loops over the tail objects and removes each with `RGWRados::delete_raw_obj_aio()` however, this was removing the objects with `cls_rgw_remove_obj()`, which is for head objects, not tails. tail objects must be removed with `cls_refcount_put()`, which preserves them until the last copy is removed rename `delete_raw_obj_aio()` to `delete_tail_obj_aio()` to clarify its purpose Fixes: https://tracker.ceph.com/issues/73348 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 1fba459)
adc2112 to
515f734
Compare
Contributor
Author
maybe a rebase will fix 🤞 |
Contributor
|
jenkins test make check |
Contributor
Author
|
jenkins test submodules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/73596
backport of #65772
parent tracker: https://tracker.ceph.com/issues/73348
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh