Skip to content

tentacle: rgw: fix 'bucket rm --bypass-gc' for copied objects#66004

Merged
cbodley merged 1 commit intoceph:tentaclefrom
cbodley:wip-73596-tentacle
Dec 9, 2025
Merged

tentacle: rgw: fix 'bucket rm --bypass-gc' for copied objects#66004
cbodley merged 1 commit intoceph:tentaclefrom
cbodley:wip-73596-tentacle

Conversation

@cbodley
Copy link
Copy Markdown
Contributor

@cbodley cbodley commented Oct 21, 2025

backport tracker: https://tracker.ceph.com/issues/73596


backport of #65772
parent tracker: https://tracker.ceph.com/issues/73348

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@anrao19
Copy link
Copy Markdown
Contributor

anrao19 commented Nov 21, 2025

pr testing completed and approved by @ivancich , details : https://tracker.ceph.com/issues/73809
pr can be merged once we get review

@anrao19
Copy link
Copy Markdown
Contributor

anrao19 commented Nov 21, 2025

jenkins render docs

@anrao19
Copy link
Copy Markdown
Contributor

anrao19 commented Dec 1, 2025

jenkins render docs

@anrao19
Copy link
Copy Markdown
Contributor

anrao19 commented Dec 1, 2025

jenkins test docs

the `--bypass-gc` argument to `radosgw-admin bucket rm` causes us to
call `RadosBucket::remove_bypass_gc()`, which loops over the tail
objects and removes each with `RGWRados::delete_raw_obj_aio()`

however, this was removing the objects with `cls_rgw_remove_obj()`,
which is for head objects, not tails. tail objects must be removed with
`cls_refcount_put()`, which preserves them until the last copy is
removed

rename `delete_raw_obj_aio()` to `delete_tail_obj_aio()` to clarify its
purpose

Fixes: https://tracker.ceph.com/issues/73348

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 1fba459)
@cbodley cbodley force-pushed the wip-73596-tentacle branch from adc2112 to 515f734 Compare December 1, 2025 15:05
@cbodley
Copy link
Copy Markdown
Contributor Author

cbodley commented Dec 1, 2025

jenkins test docs

maybe a rebase will fix 🤞

@anrao19
Copy link
Copy Markdown
Contributor

anrao19 commented Dec 9, 2025

jenkins test make check

@cbodley
Copy link
Copy Markdown
Contributor Author

cbodley commented Dec 9, 2025

jenkins test submodules

@cbodley cbodley merged commit a01c82a into ceph:tentacle Dec 9, 2025
11 checks passed
@cbodley cbodley deleted the wip-73596-tentacle branch December 9, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants