rgw: fix 'bucket rm --bypass-gc' for copied objects#65772
Merged
Conversation
the `--bypass-gc` argument to `radosgw-admin bucket rm` causes us to call `RadosBucket::remove_bypass_gc()`, which loops over the tail objects and removes each with `RGWRados::delete_raw_obj_aio()` however, this was removing the objects with `cls_rgw_remove_obj()`, which is for head objects, not tails. tail objects must be removed with `cls_refcount_put()`, which preserves them until the last copy is removed rename `delete_raw_obj_aio()` to `delete_tail_obj_aio()` to clarify its purpose Fixes: https://tracker.ceph.com/issues/73348 Signed-off-by: Casey Bodley <cbodley@redhat.com>
ivancich
approved these changes
Oct 9, 2025
Contributor
Author
|
jenkins test make check arm64 |
14 tasks
Contributor
Author
|
jenkins test make check arm64 |
This was referenced Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
--bypass-gcargument toradosgw-admin bucket rmcauses us to callRadosBucket::remove_bypass_gc(), which loops over the tail objects and removes each withRGWRados::delete_raw_obj_aio()however, this was removing the objects with
cls_rgw_remove_obj(), which is for head objects, not tails. tail objects must be removed withcls_refcount_put(), which preserves them until the last copy is removedrename
delete_raw_obj_aio()todelete_tail_obj_aio()to clarify its purposeFixes: https://tracker.ceph.com/issues/73348
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.