os/bluestore: complete fix for extent spanning over shard boundaries#65065
Merged
os/bluestore: complete fix for extent spanning over shard boundaries#65065
Conversation
65b3d1a to
b99610e
Compare
14 tasks
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test make check |
aclamk
reviewed
Aug 27, 2025
aclamk
reviewed
Aug 27, 2025
| dout(20) << __func__ << " un-spanning " << *extent->blob << dendl; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Regarding https://github.com/ceph/ceph/pull/65065/files#diff-6f3b1a5dcf5313dc06f71ba4997ee28ec219ecb5633a728b916465c684f1d87dR3944
How about getting rid of mute for was_too_many_blobs_check, and instead cure object that has the horrible amount of spanning blobs? Do sparse-read, punch_hole, write all back again ?
aclamk
reviewed
Aug 27, 2025
aclamk
reviewed
Aug 27, 2025
aclamk
reviewed
Aug 27, 2025
aclamk
reviewed
Aug 27, 2025
…d action phases Refactored ExtentMap::reshard() by splitting it into two distinct functions: - reshard_decision(): Determines the resharding plan by analyzing shard distribution, extent sizes, and spanning blob ranges - reshard_action(): Applies the resharding plan, handling faulting, key removals, and shard updates Signed-off-by: Jaya Prakash <jayaprakash@ibm.com> (cherry picked from commit 44f93a6)
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit a7f0829)
Intended for UT simplication only. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Make sure that spanning blobs are not allowed to have extents crossing shard boundary. Partially fixes: https://tracker.ceph.com/issues/70390 Signed-off-by: Adam Kupczyk <akupczyk@ibm.com> (cherry picked from commit ce05ade)
dirty_range used to have length = 1 byte. This is good if whole extent is inside shard. But this has proven not to be the case. dirty_range(offset, length) is slower only when it crosses shard. Partially fixes: https://tracker.ceph.com/issues/70390 Signed-off-by: Adam Kupczyk <akupczyk@ibm.com> (cherry picked from commit 4f566ea)
Partially fixes: https://tracker.ceph.com/issues/70390 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
b99610e to
5beee2a
Compare
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test api |
Contributor
aclamk
approved these changes
Oct 7, 2025
Contributor
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on and includes: #62816 and #62263
Fixes: https://tracker.ceph.com/issues/70390
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition