os/bluestore: Refactoring reshard_range#62263
Closed
Jayaprakash-ibm wants to merge 1 commit intoceph:mainfrom
Closed
os/bluestore: Refactoring reshard_range#62263Jayaprakash-ibm wants to merge 1 commit intoceph:mainfrom
Jayaprakash-ibm wants to merge 1 commit intoceph:mainfrom
Conversation
batrick
requested changes
Mar 12, 2025
Member
batrick
left a comment
There was a problem hiding this comment.
Please title your commits according to the conventions of this project. This is required for your PR to be merged.
See this article on GitHub on how to amend commits and update your pull request.
Member
|
Your commit should also have a rationale for the change. |
f2e0a9f to
a74137a
Compare
…d action phases Refactored ExtentMap::reshard() by splitting it into two distinct functions: - reshard_decision(): Determines the resharding plan by analyzing shard distribution, extent sizes, and spanning blob ranges - reshard_action(): Applies the resharding plan, handling faulting, key removals, and shard updates Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
a74137a to
44f93a6
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
ExtentMap::reshard()by splitting it into two distinct functions:reshard_decision(): Determines the resharding plan by analyzing shard distribution, extent sizes, and spanning blob ranges.reshard_action(): Applies the resharding plan, handling faulting, key removals, and shard updates.Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition