squid: qa: fix multi-fs tests in test_mds_metrics.py#64336
Merged
hkadam134 merged 2 commits intoceph:squidfrom Jul 25, 2025
Merged
squid: qa: fix multi-fs tests in test_mds_metrics.py#64336hkadam134 merged 2 commits intoceph:squidfrom
hkadam134 merged 2 commits intoceph:squidfrom
Conversation
* Fix _setup_fs to reconfigure only the appropriate client auth caps, by avoiding iterating the self.mounts. * Delete unused filesystems in test_perf_stats_stale_metrics_with_multiple_filesystem. Signed-off-by: Jos Collin <jcollin@redhat.com> (cherry picked from commit 7ac14ca)
* Avoids the unnecessary setup, when writing a multi-fs test. Avoids creating the default filesystem, deleting it and creating the required filesystems, mounting them. This change uses the filesystems created using 'REQUIRE_BACKUP_FILESYSTEM' for conducting tests. * This change consequently fixes the old/deleted filesystems appearing in the `perf stats` output, making it stale output. * Drops unused function parameters. Fixes: https://tracker.ceph.com/issues/68001 Fixes: https://tracker.ceph.com/issues/68446 Signed-off-by: Jos Collin <jcollin@redhat.com> (cherry picked from commit eaf2a83)
Member
Author
|
jenkins test make check |
1 similar comment
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test make check |
Member
Author
|
@hkadam134 This is ready for qa. Please add it to your upcoming batch. |
Member
Author
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/72242 |
Member
Author
|
@hkadam134 @vshankar Please approve. |
Contributor
|
squid wiki updated and acknowledged by Jos -- |
vshankar
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/71950
backport tracker: https://tracker.ceph.com/issues/71953
backport of #62842
parent tracker: https://tracker.ceph.com/issues/68446
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh