qa: fix multi-fs tests in test_mds_metrics.py#62842
Merged
Conversation
Member
Author
|
jenkins test make check |
Contributor
|
@neesingh-rh PTAL for review. |
neesingh-rh
reviewed
Jun 17, 2025
Contributor
neesingh-rh
left a comment
There was a problem hiding this comment.
Rest LGTM. Hope , now we won't be facing those failures again and again
* Avoids the unnecessary setup, when writing a multi-fs test. Avoids creating the default filesystem, deleting it and creating the required filesystems, mounting them. This change uses the filesystems created using 'REQUIRE_BACKUP_FILESYSTEM' for conducting tests. * This change consequently fixes the old/deleted filesystems appearing in the `perf stats` output, making it stale output. * Drops unused function parameters. Fixes: https://tracker.ceph.com/issues/68001 Fixes: https://tracker.ceph.com/issues/68446 Signed-off-by: Jos Collin <jcollin@redhat.com>
8636b8f to
eaf2a83
Compare
Member
Author
Yeah, no more stale perf stats o/p while comparing. |
Member
Author
|
jenkins test api |
neesingh-rh
approved these changes
Jun 20, 2025
Member
Author
|
@neesingh-rh Thanks. |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71820. |
Member
Author
vshankar
approved these changes
Jul 3, 2025
Contributor
|
@joscollin please merge. |
This was referenced Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REQUIRE_BACKUP_FILESYSTEMfor conducting tests.perf statsoutput and thus making it stale output. This is the reason the trackers (below) are attached. It was not the right way to setup a multi-fs test and there are no issues with the mgr o/p.Fixes: https://tracker.ceph.com/issues/68001
Fixes: https://tracker.ceph.com/issues/68446
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition