Skip to content

qa: fix multi-fs tests in test_mds_metrics.py#62842

Merged
joscollin merged 1 commit intoceph:mainfrom
joscollin:wip-B68001-B68446
Jul 3, 2025
Merged

qa: fix multi-fs tests in test_mds_metrics.py#62842
joscollin merged 1 commit intoceph:mainfrom
joscollin:wip-B68001-B68446

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Apr 16, 2025

  • This change is a better way of setting up multi-fs tests.
  • Avoids the unnecessary setup, when writing a multi-fs test. Avoids creating the default filesystem, deleting it and creating the required filesystems, mounting them. Instead, it uses the filesystems created using REQUIRE_BACKUP_FILESYSTEM for conducting tests.
  • This change consequently fixes the old/deleted filesystems appearing in the perf stats output and thus making it stale output. This is the reason the trackers (below) are attached. It was not the right way to setup a multi-fs test and there are no issues with the mgr o/p.
  • Drops unused function parameters.

Fixes: https://tracker.ceph.com/issues/68001
Fixes: https://tracker.ceph.com/issues/68446

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@joscollin joscollin added the cephfs Ceph File System label Apr 16, 2025
@github-actions github-actions bot added the tests label Apr 16, 2025
@joscollin
Copy link
Member Author

jenkins test make check

@joscollin joscollin requested review from a team and neesingh-rh April 16, 2025 14:11
@vshankar
Copy link
Contributor

@neesingh-rh PTAL for review.

Copy link
Contributor

@neesingh-rh neesingh-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Hope , now we won't be facing those failures again and again

* Avoids the unnecessary setup, when writing a multi-fs test.
  Avoids creating the default filesystem, deleting it and creating the required filesystems, mounting them.
  This change uses the filesystems created using 'REQUIRE_BACKUP_FILESYSTEM' for conducting tests.
* This change consequently fixes the old/deleted filesystems appearing in the `perf stats` output,
  making it stale output.
* Drops unused function parameters.

Fixes: https://tracker.ceph.com/issues/68001
Fixes: https://tracker.ceph.com/issues/68446
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-B68001-B68446 branch from 8636b8f to eaf2a83 Compare June 17, 2025 12:16
@joscollin
Copy link
Member Author

Hope , now we won't be facing those failures again and again

Yeah, no more stale perf stats o/p while comparing.

@joscollin joscollin requested a review from neesingh-rh June 17, 2025 13:27
@joscollin
Copy link
Member Author

jenkins test api

@joscollin
Copy link
Member Author

@neesingh-rh Thanks.

@hkadam134
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/71820.

@vshankar
Copy link
Contributor

vshankar commented Jul 3, 2025

@joscollin please merge.

@joscollin joscollin merged commit a4fc09e into ceph:main Jul 3, 2025
13 checks passed
@joscollin joscollin deleted the wip-B68001-B68446 branch July 3, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants