Merged
Conversation
We recently had ABI changes[1] with respect to APIs from chown() family which calls for a change in major version. Native users of the library may not have to change their code but expected sizes differ when data type for parameters are changed. However go-ceph, Go bindings for ceph, couldn't build[2] unless the ABI change is made visible to the consumers of the API. Following the Semantic Versioning guidelines[3] we reset minor and patch (extra) versions to 0. [1] ceph#62934 [2] ceph/go-ceph#1119 [3] https://semver.org/#spec-item-8 Fixes: https://tracker.ceph.com/issues/71519 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Contributor
Author
|
jenkins test api |
vshankar
reviewed
Jun 5, 2025
vshankar
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently had ABI changes #62934 with respect to APIs from chown() family which calls for a change in major version. Native users of the library may not have to change their code but expected sizes differ when data type for parameters are changed. However go-ceph, Go bindings for ceph, couldn't build ceph/go-ceph#1119 unless the ABI change is made visible to the consumers of the API. Following the Semantic Versioning guidelines we reset minor and patch (extra) versions to 0.
Fixes: https://tracker.ceph.com/issues/71519