client: do not check file size when inode does not have Fc caps by vshankar · Pull Request #63383 · ceph/ceph

vshankar · 2025-05-20T13:43:34Z

Fixes: https://tracker.ceph.com/issues/70726

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

src/test/libcephfs/test.cc

anoopcs9 · 2025-05-20T15:22:24Z

Oh..I see that this is not an issue with squid because the problematic check for in->size was only introduced as part of #59987. Please keep in mind that we should successfully get past those tests with object cacher disabled.

vshankar · 2025-05-21T05:59:28Z

Fixed and updated.

anoopcs9

I can confirm that the torture test case from which the regression (reported via samba-in-kubernetes/sit-test-cases#100) was detected can now successfully complete with the changes from the PR.

kotreshhr

lgtm otherwise

src/client/Client.cc

anoopcs9

lgtm, thanks.

github-actions · 2025-05-29T05:38:42Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

vshankar · 2025-05-29T12:50:39Z

rebased and updated.

vshankar · 2025-05-29T13:41:27Z

This PR is under test in https://tracker.ceph.com/issues/71496.

vshankar · 2025-06-01T10:42:20Z

This PR is under test in https://tracker.ceph.com/issues/71496.

This is now being tested in https://tracker.ceph.com/issues/71514

anoopcs9 · 2025-06-02T05:31:38Z

jenkins test windows

anoopcs9 · 2025-06-03T06:32:25Z

jenkins test windows

anoopcs9 · 2025-06-04T15:00:48Z

jenkins test windows

vshankar · 2025-06-05T03:56:39Z

fs suite is currently experiencing unrelated test failures which is being debugged. will restart testing when its resolved.

anoopcs9 · 2025-06-10T08:26:57Z

jenkins test windows

anoopcs9 · 2025-06-15T09:16:50Z

jenkins test windows

anoopcs9 · 2025-06-16T06:00:57Z

@vshankar Is this good to be merged?

vshankar · 2025-06-16T06:08:52Z

@vshankar Is this good to be merged?

We ran into a couple of unrelated issues from the last 2 weeks (testing kernel bug, teutholgoy slowness). Now that the tests have run, this will get merged pretty soon.

vshankar · 2025-06-18T09:10:10Z

This change will conflict with #63636 once merged, so I'm delaying testing since it would need a rebase. But, this will get merged soon.

vshankar · 2025-06-18T12:57:16Z

This change will conflict with #63636 once merged, so I'm delaying testing since it would need a rebase. But, this will get merged soon.

I have included this change in https://tracker.ceph.com/issues/71496 as PR #63636 has received more comments and needs windows build fix. Let's get this merged first!

vshankar · 2025-06-19T04:40:53Z

libcephfs tests pass: https://pulpito.ceph.com/vshankar-2025-06-19_03:50:56-fs-wip-vshankar-testing-20250618.123141-debug-testing-default-smithi/

vshankar · 2025-06-19T04:41:01Z

jenkins test windows

anoopcs9 · 2025-06-19T05:43:41Z

@vshankar I see the same failure you mentioned in #63636 (comment).

vshankar · 2025-06-19T05:51:55Z

@vshankar I see the same failure you mentioned in #63636 (comment).

oh, windows w/ O_NONBLOCK :/

vshankar · 2025-06-19T05:52:08Z

(hang on -- let me fix this up)

vshankar · 2025-06-19T05:54:41Z

I think its safe to not use O_NONBLOCK

anoopcs9 · 2025-06-19T06:09:54Z

I think its safe to not use O_NONBLOCK

At least for this particular test case O_NONBLOCK shouldn't matter I guess. Feel free to take it out.

Since the client is holding Fr caps, the read request can be directly sent to the OSD. The offset/in->size comparison check is causing the read request to return with no data since in->size isn't yet updated when another client does an extending write. Introduced-by: 942474c Fixes: http://tracker.ceph.com/issues/70726 Signed-off-by: Venky Shankar <vshankar@redhat.com>

@anoopcs9

Credit to @anoopcs9 for the reproducer. Signed-off-by: Venky Shankar <vshankar@redhat.com>

vshankar · 2025-06-19T13:30:34Z

Update with O_NONBLOCK flag removed. Ran test locally

➜  build git:(wip-70726) ✗ ./bin/ceph_test_libcephfs --gtest_filter=LibCephFS.AsyncReadAndWriteMultiClient
Note: Google Test filter = LibCephFS.AsyncReadAndWriteMultiClient
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from LibCephFS
[ RUN      ] LibCephFS.AsyncReadAndWriteMultiClient
: waiting for write to finish
written=131072
: write finished
: waiting for read to finish
read=131072
: read finished
[       OK ] LibCephFS.AsyncReadAndWriteMultiClient (1362 ms)
[----------] 1 test from LibCephFS (1362 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1362 ms total)
[  PASSED  ] 1 test.

vshankar · 2025-06-20T06:50:22Z

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20250618123141-debug

* refs/pull/63383/head: test: multi client file read/write test for extending writes client: do not check file size when inode does not have Fc caps Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com> Reviewed-by: Anoop C S <anoopcs@cryptolab.net>

vshankar requested a review from a team May 20, 2025 13:43

vshankar added the cephfs Ceph File System label May 20, 2025

github-actions bot added the tests label May 20, 2025

anoopcs9 requested changes May 20, 2025

View reviewed changes

src/test/libcephfs/test.cc Show resolved Hide resolved

vshankar force-pushed the wip-70726 branch from e887683 to 3cd23f0 Compare May 21, 2025 05:58

vshankar requested a review from kotreshhr May 21, 2025 05:58

anoopcs9 reviewed May 21, 2025

View reviewed changes

vshankar added the wip-vshankar-testing label May 25, 2025

kotreshhr reviewed May 27, 2025

View reviewed changes

src/client/Client.cc Show resolved Hide resolved

vshankar force-pushed the wip-70726 branch from 3cd23f0 to 5c94f43 Compare May 27, 2025 09:24

vshankar requested a review from kotreshhr May 27, 2025 09:24

kotreshhr approved these changes May 27, 2025

View reviewed changes

anoopcs9 approved these changes May 27, 2025

View reviewed changes

github-actions bot added the needs-rebase label May 29, 2025

vshankar force-pushed the wip-70726 branch from 5c94f43 to c0264f2 Compare May 29, 2025 12:50

github-actions bot removed the needs-rebase label May 29, 2025

vshankar added wip-vshankar-testing4 and removed wip-vshankar-testing labels Jun 1, 2025

vshankar added wip-vshankar-testing5 and removed wip-vshankar-testing4 labels Jun 10, 2025

vshankar added wip-vshankar-testing and removed wip-vshankar-testing5 labels Jun 18, 2025

vshankar added 2 commits June 19, 2025 08:53

test: multi client file read/write test for extending writes

624cb4c

Credit to @anoopcs9 for the reproducer. Signed-off-by: Venky Shankar <vshankar@redhat.com>

vshankar force-pushed the wip-70726 branch from c0264f2 to 624cb4c Compare June 19, 2025 08:53

vshankar merged commit daff912 into ceph:main Jun 20, 2025
13 checks passed

vshankar removed the wip-vshankar-testing label Jun 20, 2025

anoopcs9 mentioned this pull request Jun 20, 2025

CephFS: smb2.rw.rw1 fails with NT_STATUS_END_OF_FILE on vfs_ceph_new shares samba-in-kubernetes/sit-test-cases#100

Closed

Conversation

vshankar commented May 20, 2025

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

anoopcs9 commented May 20, 2025

Uh oh!

vshankar commented May 21, 2025

Uh oh!

anoopcs9 left a comment

Choose a reason for hiding this comment

Uh oh!

kotreshhr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anoopcs9 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

vshankar commented May 29, 2025

Uh oh!

vshankar commented May 29, 2025

Uh oh!

vshankar commented Jun 1, 2025

Uh oh!

anoopcs9 commented Jun 2, 2025

Uh oh!

anoopcs9 commented Jun 3, 2025

Uh oh!

anoopcs9 commented Jun 4, 2025

Uh oh!

vshankar commented Jun 5, 2025

Uh oh!

anoopcs9 commented Jun 10, 2025

Uh oh!

anoopcs9 commented Jun 15, 2025

Uh oh!

anoopcs9 commented Jun 16, 2025

Uh oh!

vshankar commented Jun 16, 2025

Uh oh!

vshankar commented Jun 18, 2025

Uh oh!

vshankar commented Jun 18, 2025

Uh oh!

vshankar commented Jun 19, 2025

Uh oh!

vshankar commented Jun 19, 2025

Uh oh!

anoopcs9 commented Jun 19, 2025

Uh oh!

vshankar commented Jun 19, 2025

Uh oh!

vshankar commented Jun 19, 2025

Uh oh!

vshankar commented Jun 19, 2025

Uh oh!

anoopcs9 commented Jun 19, 2025

Uh oh!

vshankar commented Jun 19, 2025

Uh oh!

vshankar commented Jun 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants