Skip to content

qa/cephfs: replace deprecated assertEquals with assertEqual#63323

Merged
vshankar merged 2 commits intoceph:mainfrom
emmanuel-ferdman:main
Jun 20, 2025
Merged

qa/cephfs: replace deprecated assertEquals with assertEqual#63323
vshankar merged 2 commits intoceph:mainfrom
emmanuel-ferdman:main

Conversation

@emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 16, 2025 •
edited
Loading

The unittest.TestCase.assertEquals() method is deprecated in Python 2.7
and emits a DeprecationWarning. This commit replaces all instances of
assertEquals() with the recommended assertEqual() in the cephfs test files
to resolve these warnings and ensure future compatibility.

This change addresses warnings such as:
DeprecationWarning: Please use assertEqual instead.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added cephfs Ceph File System tests labels May 16, 2025
tchaikov
tchaikov reviewed May 18, 2025
View reviewed changes
@emmanuel-ferdman
qa/cephfs: replace deprecated assertEquals with assertEqual
3572da7 
The unittest.TestCase.assertEquals() method is deprecated in Python 2.7
and emits a DeprecationWarning. This commit replaces all instances of
assertEquals() with the recommended assertEqual() in the cephfs test files
to resolve these warnings and ensure future compatibility.

This change addresses warnings such as:
DeprecationWarning: Please use assertEqual instead.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman emmanuel-ferdman changed the title qa: resolve Python testing warnings qa/cephfs: replace deprecated assertEquals with assertEqual May 18, 2025
tchaikov
tchaikov approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joscollin joscollin requested a review from a team May 19, 2025 05:21
@joscollin
Copy link
Member

joscollin commented May 21, 2025

jenkins test api

@joscollin
Copy link
Member

joscollin commented May 22, 2025

@rishabh-d-dave If you are doing the QA, please add this PR in your next batch.

@joscollin
Copy link
Member

joscollin commented May 26, 2025

@vshankar As informed via slack, please take this for QA.

@github-actions
Copy link

github-actions bot commented May 29, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@emmanuel-ferdman
Merge branch 'main' into main
1a89753 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@vshankar
Copy link
Contributor

vshankar commented May 29, 2025

This PR is under test in https://tracker.ceph.com/issues/71496.

vshankar added a commit to vshankar/ceph that referenced this pull request Jun 9, 2025
@vshankar
Merge PR ceph#63323 into wip-vshankar-testing-20250601.092447-debug
022f237 
* refs/pull/63323/head:
	Merge branch 'main' into main
	qa/cephfs: replace deprecated assertEquals with assertEqual

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
@joscollin
Copy link
Member

joscollin commented Jun 10, 2025

jenkins test windows

@joscollin
Copy link
Member

joscollin commented Jun 10, 2025

jenkins test make check arm64

@vshankar
Copy link
Contributor

vshankar commented Jun 10, 2025

@vshankar I see that the CI fails but I don't see why. Could you please check it out? thanks 🙌

Possibly unrelated. I will check.

@vshankar
Copy link
Contributor

vshankar commented Jun 10, 2025

jenkins test make check arm64

@vshankar
Copy link
Contributor

vshankar commented Jun 18, 2025

@vshankar @joscollin looks like all good now

Yes. This is good to go once we get the tests running. We have faced multiple issues lately.

vshankar
vshankar approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20250618123141-debug

@vshankar vshankar merged commit e84c562 into ceph:main Jun 20, 2025
12 checks passed
vshankar added a commit to vshankar/ceph that referenced this pull request Jun 23, 2025
@vshankar
Merge PR ceph#63323 into wip-vshankar-testing-20250618.123141-debug
76cf49a 
* refs/pull/63323/head:
	Merge branch 'main' into main
	qa/cephfs: replace deprecated assertEquals with assertEqual

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
@batrick
Copy link
Member

batrick commented Feb 26, 2026

this needed a tracker ticket

@batrick
Copy link
Member

batrick commented Feb 26, 2026

https://tracker.ceph.com/issues/75210

@emmanuel-ferdman
Copy link
Contributor Author

emmanuel-ferdman commented Feb 26, 2026 •
edited
Loading

@batrick Fix already in main via this PR - just needs backport to squid and maybe other branches. Let me know if you prefer me to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@vshankar vshankar vshankar approved these changes

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@joscollin joscollin joscollin approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System needs-qa tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@emmanuel-ferdman @joscollin @vshankar @batrick @tchaikov @rishabh-d-dave