rgw: move rados-specific parts of RGWRealmWatcher into ConfigStore#63189
Merged
rgw: move rados-specific parts of RGWRealmWatcher into ConfigStore#63189
Conversation
e8433d1 to
1fa1650
Compare
adamemerson
approved these changes
May 8, 2025
| // add a watcher to respond to realm configuration changes | ||
| // if we're part of a realm, add a watcher to respond to configuration changes | ||
| if (const auto& realm = env.site->get_realm(); realm) { | ||
| realm_watcher = env.cfgstore->create_realm_watcher(dpp, null_yield, *realm); |
dang
approved these changes
May 9, 2025
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
This was referenced May 19, 2025
Contributor
Author
split RGWRealmWatcher in two halves, moving the rados-specific stuff into a RadosRealmWatcher that inherits from RGWRealmWatcher add factory function ConfigStore::create_realm_watcher() that returns a generic RGWRealmWatcher. ConfigStore backends that don't support watch/notify can return nullptr rgw::AppMain uses this to avoid relying on checking for a "rados" driver name, which doesn't work correctly when there are filters on top of the RadosStore Signed-off-by: Casey Bodley <cbodley@redhat.com>
905166b to
e70d932
Compare
Contributor
Author
|
squashed/rebased |
Contributor
Author
|
https://jenkins.ceph.com/job/ceph-api/96171/ no idea what failed there |
Contributor
Author
|
jenkins test api |
Contributor
Author
|
https://jenkins.ceph.com/job/ceph-api/96196/
the api tests passed but it was still marked as a failure.. 🤷 |
Contributor
Author
|
jenkins test api |
cbodley
added a commit
to cbodley/ceph
that referenced
this pull request
Mar 18, 2026
in ceph#63189 i did the work to hide the rados-specific bits behind the ConfigStore interface. backends that don't support watch/notify return nullptr from create_realm_watcher(), so it doesn't need to be guarded by ifdef Signed-off-by: Casey Bodley <cbodley@redhat.com>
This was referenced Mar 18, 2026
cbodley
added a commit
to cbodley/ceph
that referenced
this pull request
Mar 18, 2026
in ceph#63189 i did the work to hide the rados-specific bits behind the ConfigStore interface. backends that don't support watch/notify return nullptr from create_realm_watcher(), so it doesn't need to be guarded by ifdef Signed-off-by: Casey Bodley <cbodley@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split RGWRealmWatcher in two halves, moving the rados-specific stuff into a RadosRealmWatcher that inherits from RGWRealmWatcher
add factory function ConfigStore::create_realm_watcher() that returns a generic RGWRealmWatcher. ConfigStore backends that don't support watch/notify can return nullptr
rgw::AppMain uses this to avoid relying on checking for a "rados" driver name, which doesn't work correctly when there are filters on top of the RadosStore
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition