squid: mds: check for snapshots on parent snaprealms#63019
Merged
joscollin merged 4 commits intoceph:squidfrom Sep 23, 2025
Merged
squid: mds: check for snapshots on parent snaprealms#63019joscollin merged 4 commits intoceph:squidfrom
joscollin merged 4 commits intoceph:squidfrom
Conversation
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 89d3fb0)
This allows false/true as a value. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 58e5c94)
The code was incorrectly only looking at snapshots in the current snaprealm. Fixes: https://tracker.ceph.com/issues/70912 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit b8fd8e7)
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 05ca22f)
Member
|
This PR is under test in https://tracker.ceph.com/issues/72883. |
joscollin
reviewed
Sep 23, 2025
Member
joscollin
left a comment
There was a problem hiding this comment.
This needs a rerun separately as charmap is not involved in QA somehow.
Member
|
joscollin
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/71094
backport of #62833
parent tracker: https://tracker.ceph.com/issues/70912
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh