Skip to content

mds: check for snapshots on parent snaprealms#62833

Merged
batrick merged 4 commits intoceph:mainfrom
batrick:i70912
Apr 25, 2025
Merged

mds: check for snapshots on parent snaprealms#62833
batrick merged 4 commits intoceph:mainfrom
batrick:i70912

Conversation

@batrick
Copy link
Member

@batrick batrick commented Apr 15, 2025 •
edited
Loading

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added cephfs Ceph File System common tests labels Apr 15, 2025
batrick added 4 commits April 16, 2025 10:01
@batrick
common: take string_view for strict_tobool
89d3fb0 
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
mds: use strict_strtobool for parsing bools
58e5c94 
This allows false/true as a value.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
mds: check for snapshots on parent snaprealms
b8fd8e7 
The code was incorrectly only looking at snapshots in the current snaprealm.

Fixes: https://tracker.ceph.com/issues/70912
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
qa: test charmap changes with dir and snaps
05ca22f 
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick batrick marked this pull request as ready for review April 16, 2025 14:56
@batrick
Copy link
Member Author

batrick commented Apr 16, 2025

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Apr 16, 2025

jenkins test api

@batrick
Copy link
Member Author

batrick commented Apr 17, 2025

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Apr 17, 2025

jenkins test api

1 similar comment
@batrick
Copy link
Member Author

batrick commented Apr 17, 2025

jenkins test api

@batrick batrick changed the title mds: permit charmap changes on empty directory with snapshots mds: check for snapshots on parent snaprealms Apr 17, 2025
@batrick
Copy link
Member Author

batrick commented Apr 21, 2025

This PR is under test in https://tracker.ceph.com/issues/71000.

@batrick batrick requested a review from a team April 25, 2025 02:42
gregsfortytwo
gregsfortytwo approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@gregsfortytwo gregsfortytwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Greg Farnum gfarnum@redhat.com

@batrick batrick merged commit ed7bb4f into ceph:main Apr 25, 2025
21 checks passed
@batrick batrick deleted the i70912 branch April 25, 2025 19:00
@batrick batrick mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregsfortytwo gregsfortytwo gregsfortytwo approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System common needs-review tests wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@batrick @gregsfortytwo