Skip to content

rgw: add metric when send message with kafka and ampq#62971

Merged
yuvalif merged 1 commit intoceph:mainfrom
thuvh:feat_rgw_pubsub_push_metric
Oct 11, 2025
Merged

rgw: add metric when send message with kafka and ampq#62971
yuvalif merged 1 commit intoceph:mainfrom
thuvh:feat_rgw_pubsub_push_metric

Conversation

@thuvh
Copy link
Contributor

@thuvh thuvh commented Apr 25, 2025 •
edited
Loading

  • l_rgw_pubsub_push_pending
  • l_rgw_pubsub_push_failed

Fixes: 70256

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Apr 25, 2025

Can one of the admins verify this patch?

@github-actions github-actions bot added the rgw label Apr 25, 2025
@thuvh thuvh force-pushed the feat_rgw_pubsub_push_metric branch from 397ed95 to 438e04b Compare April 25, 2025 09:10
@thuvh thuvh marked this pull request as ready for review April 25, 2025 09:10
@thuvh thuvh requested a review from a team as a code owner April 25, 2025 09:10
@thuvh thuvh force-pushed the feat_rgw_pubsub_push_metric branch from 438e04b to 6893806 Compare April 25, 2025 09:32
@thuvh
Copy link
Contributor Author

thuvh commented Apr 26, 2025

jenkins test make check arm64

yuvalif
yuvalif reviewed May 5, 2025
View reviewed changes
yuvalif
yuvalif reviewed May 5, 2025
View reviewed changes
src/rgw/driver/rados/rgw_pubsub_push.cc
}
});
return w.async_wait(yield);
const auto rc = w.async_wait(yield);
Copy link
Contributor

@yuvalif yuvalif May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as in the amqp case

@yuvalif
Copy link
Contributor

yuvalif commented May 5, 2025

you are missing this from the tracker:

"l_rgw_pubsub_push_failed" are not incremented for persistent notifications. should be incremented only when we give up on retries

note that for persistent notifications there will be no error code retuned to rgw_pubsub_push.cc. a "sucess" will be returned once the "publish" operation is successfull.
errors will be handled and retried in "rgw_notify.cc". the error counter should be incremented only once we give up on retries.

@thuvh thuvh force-pushed the feat_rgw_pubsub_push_metric branch 6 times, most recently from 1066af3 to 7aeb108 Compare June 5, 2025 09:13
@thuvh
Copy link
Contributor Author

thuvh commented Jun 5, 2025

jenkins test make check

@thuvh
Copy link
Contributor Author

thuvh commented Jun 5, 2025

jenkins test signed

@github-actions
Copy link

github-actions bot commented Jun 30, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

github-actions bot commented Aug 29, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 29, 2025
@adamemerson adamemerson removed the stale label Sep 12, 2025
@adamemerson
Copy link
Contributor

adamemerson commented Sep 12, 2025

@thuvh Please rebase

@thuvh
Copy link
Contributor Author

thuvh commented Sep 13, 2025

@adamemerson ok, I will rebase next Monday.

@thuvh thuvh force-pushed the feat_rgw_pubsub_push_metric branch from 7aeb108 to 10a0d61 Compare September 21, 2025 07:03
@thuvh
Copy link
Contributor Author

thuvh commented Sep 21, 2025

need recheck commit

@yuvalif
Copy link
Contributor

yuvalif commented Sep 29, 2025

@thuvh why is there sucn a huge change in rgw_notify.cc ?

@thuvh thuvh force-pushed the feat_rgw_pubsub_push_metric branch 2 times, most recently from 3680791 to 622c3b1 Compare October 3, 2025 19:05
@thuvh
Copy link
Contributor Author

thuvh commented Oct 3, 2025

@thuvh why is there sucn a huge change in rgw_notify.cc ?

I reverted. I made a mistake with my vscode.

@thuvh
Copy link
Contributor Author

thuvh commented Oct 3, 2025

jenkins test windows

@yuvalif yuvalif self-requested a review October 5, 2025 08:01
@yuvalif
Copy link
Contributor

yuvalif commented Oct 5, 2025

removed the "need-test" tag, as we don't have infrastructure for testing perf counters

@yuvalif yuvalif removed the needs-test label Oct 5, 2025
@anrao19
Copy link
Contributor

anrao19 commented Oct 8, 2025

jenkins test windows

@anrao19
Copy link
Contributor

anrao19 commented Oct 8, 2025

jenkins test make check arm64

@anrao19
Copy link
Contributor

anrao19 commented Oct 8, 2025

pr testing completed and approved by @ivancich. Please find the details : https://tracker.ceph.com/issues/73370
@thuvh , if there is not further testing needed this can be merged. Please let me know

@thuvh
Copy link
Contributor Author

thuvh commented Oct 8, 2025

I think it's ok. Is there any comment @yuvalif ?

@yuvalif
Copy link
Contributor

yuvalif commented Oct 8, 2025

I think it's ok. Is there any comment @yuvalif ?

thanks @thuvh will merge once CI will pass

@yuvalif
Copy link
Contributor

yuvalif commented Oct 8, 2025

jenkins test windows

@thuvh
rgw: add metric when send message with kafka and ampq
df4ef78 
- l_rgw_pubsub_push_pending
- l_rgw_pubsub_push_failed

Fixes: https://tracker.ceph.com/issues/70256

Signed-off-by: Hoai-Thu Vuong <thuvh87@gmail.com>
@thuvh thuvh force-pushed the feat_rgw_pubsub_push_metric branch from 622c3b1 to df4ef78 Compare October 8, 2025 09:39
@thuvh
Copy link
Contributor Author

thuvh commented Oct 8, 2025

I think it's ok. Is there any comment @yuvalif ?

thanks @thuvh will merge once CI will pass

just rebase

@thuvh
Copy link
Contributor Author

thuvh commented Oct 8, 2025

jenkins test make check

1 similar comment
@thuvh
Copy link
Contributor Author

thuvh commented Oct 8, 2025

jenkins test make check

@thuvh
Copy link
Contributor Author

thuvh commented Oct 8, 2025

jenkins test windows

@thuvh thuvh requested a review from yuvalif October 10, 2025 14:28
@yuvalif yuvalif merged commit a0061bb into ceph:main Oct 11, 2025
13 checks passed
@thuvh thuvh deleted the feat_rgw_pubsub_push_metric branch October 11, 2025 16:06
This was referenced Oct 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuvalif yuvalif Awaiting requested review from yuvalif

Assignees

No one assigned

Labels

needs-qa ready-to-merge rgw TESTED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thuvh @ceph-jenkins @yuvalif @adamemerson @anrao19